Create retainment infos from handles, even for tracing

third_party/WebKit/Source/bindings/core/v8/V8GCController.cpp

 /*
  * Copyright (C) 2009 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 184 matching lines @@
       Node* node = V8Node::toImpl(wrapper);
       if (node->hasEventListeners())
         addReferencesForNodeWithEventListeners(
             m_isolate, node, v8::Persistent<v8::Object>::Cast(*value));
       Node* root = V8GCController::opaqueRootForGC(m_isolate, node);
       m_isolate->SetObjectGroupId(
           *value, v8::UniqueId(reinterpret_cast<intptr_t>(root)));
       if (m_constructRetainedObjectInfos)
         m_groupsWhichNeedRetainerInfo.append(root);
     } else if (classId == WrapperTypeInfo::ObjectClassId) {
-      type->visitDOMWrapper(m_isolate, toScriptWrappable(wrapper),
-                            v8::Persistent<v8::Object>::Cast(*value));
+      if (!RuntimeEnabledFeatures::traceWrappablesEnabled()) {
+        type->visitDOMWrapper(m_isolate, toScriptWrappable(wrapper),
+                              v8::Persistent<v8::Object>::Cast(*value));
+      }
     } else {
       NOTREACHED();
     }
   }
 
   void notifyFinished() {
     if (!m_constructRetainedObjectInfos)
       return;
     std::sort(m_groupsWhichNeedRetainerInfo.begin(),
               m_groupsWhichNeedRetainerInfo.end());
@@ skipping 53 matching lines @@
 
 void objectGroupingForMajorGC(v8::Isolate* isolate,
                               bool constructRetainedObjectInfos) {
   MajorGCWrapperVisitor visitor(isolate, constructRetainedObjectInfos);
   isolate->VisitHandlesWithClassIds(&visitor);
   visitor.notifyFinished();
 }
 
 void gcPrologueForMajorGC(v8::Isolate* isolate,
                           bool constructRetainedObjectInfos) {
-  // TODO(hlopko): Collect retained object infos for heap profiler
-  if (!RuntimeEnabledFeatures::traceWrappablesEnabled()) {
+  if (!RuntimeEnabledFeatures::traceWrappablesEnabled() ||
+      constructRetainedObjectInfos) {
     objectGroupingForMajorGC(isolate, constructRetainedObjectInfos);
   }
 }
 
 }  // namespace
 
 void V8GCController::gcPrologue(v8::Isolate* isolate,
                                 v8::GCType type,
                                 v8::GCCallbackFlags flags) {
   if (isMainThread())
@@ skipping 245 matching lines @@
   double startTime = WTF::currentTimeMS();
   v8::HandleScope scope(isolate);
   PendingActivityVisitor visitor(isolate, executionContext);
   toIsolate(executionContext)->VisitHandlesWithClassIds(&visitor);
   scanPendingActivityHistogram.count(
       static_cast<int>(WTF::currentTimeMS() - startTime));
   return visitor.pendingActivityFound();
 }
 
 }  // namespace blink