[interpreter] Implement support for the --trace flag.

[interpreter] Implement support for the --trace flag.

R=rmcilroy@chromium.org

Committed: https://crrev.com/9c3d08f972991e302ef040b7b6c266af16e69eba
Cr-Commit-Position: refs/heads/master@{#39979}

[Michael Starzinger, 2016-10-04 13:38:23]

The CQ bit was checked by mstarzinger@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-04 13:38:35]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-04 14:03:35]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-04 14:03:35]

Dry run: This issue passed the CQ dry run.

[rmcilroy, 2016-10-04 16:09:30]

LGTM, thanks.

https://codereview.chromium.org/2387363003/diff/20001/src/interpreter/bytecod...
File src/interpreter/bytecode-generator.cc (right):

https://codereview.chromium.org/2387363003/diff/20001/src/interpreter/bytecod...
src/interpreter/bytecode-generator.cc:1867: Runtime::kTraceExit, result);
nit - comment that Runtime::TraceExit returns the result.

[Michael Starzinger, 2016-10-05 08:18:27]

The CQ bit was checked by mstarzinger@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-05 08:18:36]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Michael Starzinger, 2016-10-05 08:21:01]

Thanks. Addressed comments. Landing.

https://codereview.chromium.org/2387363003/diff/20001/src/interpreter/bytecod...
File src/interpreter/bytecode-generator.cc (right):

https://codereview.chromium.org/2387363003/diff/20001/src/interpreter/bytecod...
src/interpreter/bytecode-generator.cc:1867: Runtime::kTraceExit, result);
On 2016/10/04 16:09:30, rmcilroy wrote:
> nit - comment that Runtime::TraceExit returns the result.

Done.

[commit-bot: I haz the power, 2016-10-05 08:48:05]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-05 08:48:06]

Dry run: This issue passed the CQ dry run.

[Michael Starzinger, 2016-10-05 09:02:11]

The CQ bit was checked by mstarzinger@chromium.org

[Michael Starzinger, 2016-10-05 09:02:11]

The patchset sent to the CQ was uploaded after l-g-t-m from
rmcilroy@chromium.org
Link to the patchset: https://codereview.chromium.org/2387363003/#ps40001
(title: "Addressed comments.")

[commit-bot: I haz the power, 2016-10-05 09:02:14]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-05 09:04:32]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-10-05 09:04:52]

Description was changed from

==========
[interpreter] Implement support for the --trace flag.

R=rmcilroy@chromium.org
==========

to

==========
[interpreter] Implement support for the --trace flag.

R=rmcilroy@chromium.org

Committed: https://crrev.com/9c3d08f972991e302ef040b7b6c266af16e69eba
Cr-Commit-Position: refs/heads/master@{#39979}
==========

[commit-bot: I haz the power, 2016-10-05 09:04:53]

Patchset 3 (id:??) landed as
https://crrev.com/9c3d08f972991e302ef040b7b6c266af16e69eba
Cr-Commit-Position: refs/heads/master@{#39979}