Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2197)

Unified Diff: content/public/browser/render_widget_host.h

Issue 2387353004: Delay Input.dispatchKeyEvent response until after key event ack. (Closed)
Patch Set: fix some review comments, fix a bug Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/public/browser/render_widget_host.h
diff --git a/content/public/browser/render_widget_host.h b/content/public/browser/render_widget_host.h
index f8bf0927032122249ad8c1a8c0e8778adacc60d4..30da6ca1b27e4793adb0f9927c55338fdd7db336 100644
--- a/content/public/browser/render_widget_host.h
+++ b/content/public/browser/render_widget_host.h
@@ -240,12 +240,13 @@ class CONTENT_EXPORT RenderWidgetHost : public IPC::Sender {
virtual void AddMouseEventCallback(const MouseEventCallback& callback) = 0;
virtual void RemoveMouseEventCallback(const MouseEventCallback& callback) = 0;
- // Observer for WebInputEvents (but not input event acks).
+ // Observer for WebInputEvents.
class InputEventObserver {
public:
virtual ~InputEventObserver() {}
virtual void OnInputEvent(const blink::WebInputEvent&) = 0;
+ virtual void OnInputEventAck(const blink::WebInputEvent&, bool) = 0;
dtapuska 2016/10/14 19:06:29 I think you need to document what this boolean rep
samuong 2016/10/20 23:36:18 Done.
};
// Add/remove an input event observer.

Powered by Google App Engine
This is Rietveld 408576698