Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1411)

Unified Diff: content/browser/renderer_host/render_widget_host_impl.cc

Issue 2387353004: Delay Input.dispatchKeyEvent response until after key event ack. (Closed)
Patch Set: fix some review comments, fix a bug Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/renderer_host/render_widget_host_impl.cc
diff --git a/content/browser/renderer_host/render_widget_host_impl.cc b/content/browser/renderer_host/render_widget_host_impl.cc
index 51461752667410033694fd108835c8510b2dbdc7..5580243df08629705a2617a7e7086905dbf863c1 100644
--- a/content/browser/renderer_host/render_widget_host_impl.cc
+++ b/content/browser/renderer_host/render_widget_host_impl.cc
@@ -1948,6 +1948,8 @@ void RenderWidgetHostImpl::OnKeyboardEventAck(
const NativeWebKeyboardEventWithLatencyInfo& event,
InputEventAckState ack_result) {
latency_tracker_.OnInputEventAck(event.event, &event.latency, ack_result);
+ FOR_EACH_OBSERVER(InputEventObserver, input_event_observers_,
+ OnInputEventAck(event.event, event.event.is_synthetic));
const bool processed = (INPUT_EVENT_ACK_STATE_CONSUMED == ack_result);
@@ -1968,6 +1970,8 @@ void RenderWidgetHostImpl::OnMouseEventAck(
InputEventAckState ack_result) {
latency_tracker_.OnInputEventAck(mouse_event.event, &mouse_event.latency,
ack_result);
+ FOR_EACH_OBSERVER(InputEventObserver, input_event_observers_,
+ OnInputEventAck(mouse_event.event, false));
}
void RenderWidgetHostImpl::OnWheelEventAck(
@@ -1975,6 +1979,8 @@ void RenderWidgetHostImpl::OnWheelEventAck(
InputEventAckState ack_result) {
latency_tracker_.OnInputEventAck(wheel_event.event, &wheel_event.latency,
ack_result);
+ FOR_EACH_OBSERVER(InputEventObserver, input_event_observers_,
+ OnInputEventAck(wheel_event.event, false));
if (!is_hidden() && view_) {
if (ack_result != INPUT_EVENT_ACK_STATE_CONSUMED &&
@@ -1989,6 +1995,8 @@ void RenderWidgetHostImpl::OnGestureEventAck(
const GestureEventWithLatencyInfo& event,
InputEventAckState ack_result) {
latency_tracker_.OnInputEventAck(event.event, &event.latency, ack_result);
+ FOR_EACH_OBSERVER(InputEventObserver, input_event_observers_,
+ OnInputEventAck(event.event, false));
if (view_)
view_->GestureEventAck(event.event, ack_result);
@@ -1998,6 +2006,8 @@ void RenderWidgetHostImpl::OnTouchEventAck(
const TouchEventWithLatencyInfo& event,
InputEventAckState ack_result) {
latency_tracker_.OnInputEventAck(event.event, &event.latency, ack_result);
+ FOR_EACH_OBSERVER(InputEventObserver, input_event_observers_,
+ OnInputEventAck(event.event, false));
if (touch_emulator_ &&
touch_emulator_->HandleTouchEventAck(event.event, ack_result)) {

Powered by Google App Engine
This is Rietveld 408576698