Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(948)

Unified Diff: content/browser/renderer_host/native_web_keyboard_event_aura.cc

Issue 2387353004: Delay Input.dispatchKeyEvent response until after key event ack. (Closed)
Patch Set: fix some review comments, fix a bug Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/renderer_host/native_web_keyboard_event_aura.cc
diff --git a/content/browser/renderer_host/native_web_keyboard_event_aura.cc b/content/browser/renderer_host/native_web_keyboard_event_aura.cc
index 4ae4a65f60120b9b13f89d00bdc1e8b589e74be8..54007fa1c5fc942ef7bc41c63d022d5222c5baaa 100644
--- a/content/browser/renderer_host/native_web_keyboard_event_aura.cc
+++ b/content/browser/renderer_host/native_web_keyboard_event_aura.cc
@@ -27,7 +27,8 @@ namespace content {
NativeWebKeyboardEvent::NativeWebKeyboardEvent()
: os_event(NULL),
- skip_in_browser(false) {
+ skip_in_browser(false),
+ is_synthetic(false) {
}
NativeWebKeyboardEvent::NativeWebKeyboardEvent(gfx::NativeEvent native_event)
@@ -37,20 +38,23 @@ NativeWebKeyboardEvent::NativeWebKeyboardEvent(gfx::NativeEvent native_event)
NativeWebKeyboardEvent::NativeWebKeyboardEvent(const ui::KeyEvent& key_event)
: WebKeyboardEvent(ui::MakeWebKeyboardEvent(key_event)),
os_event(CopyEvent(&key_event)),
- skip_in_browser(false) {}
+ skip_in_browser(false),
+ is_synthetic(false) {}
NativeWebKeyboardEvent::NativeWebKeyboardEvent(
const NativeWebKeyboardEvent& other)
: WebKeyboardEvent(other),
os_event(CopyEvent(other.os_event)),
- skip_in_browser(other.skip_in_browser) {
+ skip_in_browser(other.skip_in_browser),
+ is_synthetic(other.is_synthetic) {
}
NativeWebKeyboardEvent::NativeWebKeyboardEvent(const ui::KeyEvent& key_event,
base::char16 character)
: WebKeyboardEvent(ui::MakeWebKeyboardEvent(key_event)),
os_event(NULL),
- skip_in_browser(false) {
+ skip_in_browser(false),
+ is_synthetic(false) {
type = blink::WebInputEvent::Char;
windowsKeyCode = character;
text[0] = character;
@@ -63,6 +67,7 @@ NativeWebKeyboardEvent& NativeWebKeyboardEvent::operator=(
delete os_event;
os_event = CopyEvent(other.os_event);
skip_in_browser = other.skip_in_browser;
+ is_synthetic = other.is_synthetic;
return *this;
}

Powered by Google App Engine
This is Rietveld 408576698