chrome/browser/page_load_metrics/metrics_web_contents_observer.h - Issue 2387353004: Delay Input.dispatchKeyEvent response until after key event ack.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/page_load_metrics/metrics_web_contents_observer.h

Issue 2387353004: Delay Input.dispatchKeyEvent response until after key event ack. (Closed)

Patch Set: fix some review comments, fix a bug Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/page_load_metrics/metrics_web_contents_observer.h

diff --git a/chrome/browser/page_load_metrics/metrics_web_contents_observer.h b/chrome/browser/page_load_metrics/metrics_web_contents_observer.h

index d52a54cde7e652f03eede2e91a35f44d1b3a97d1..b7be8e26b065e9f7be302beea49a18d02dbde01f 100644

--- a/chrome/browser/page_load_metrics/metrics_web_contents_observer.h

+++ b/chrome/browser/page_load_metrics/metrics_web_contents_observer.h

@@ -334,6 +334,8 @@ class MetricsWebContentsObserver

content::NavigationHandle* navigation_handle) override;

void NavigationStopped() override;

void OnInputEvent(const blink::WebInputEvent& event) override;

+ void OnInputEventAck(const blink::WebInputEvent& event, bool is_synthetic)

+ override {};

void WasShown() override;

void WasHidden() override;

void RenderProcessGone(base::TerminationStatus status) override;