content/browser/renderer_host/native_web_keyboard_event_android.cc - Issue 2387353004: Delay Input.dispatchKeyEvent response until after key event ack.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/renderer_host/native_web_keyboard_event_android.cc

Issue 2387353004: Delay Input.dispatchKeyEvent response until after key event ack. (Closed)

Patch Set: rebase, make sure that tests build and run Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/browser/devtools/protocol/input_handler.cc ('K') | « content/browser/devtools/protocol/input_handler.cc ('k') | content/browser/renderer_host/native_web_keyboard_event_aura.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/renderer_host/native_web_keyboard_event_android.cc

diff --git a/content/browser/renderer_host/native_web_keyboard_event_android.cc b/content/browser/renderer_host/native_web_keyboard_event_android.cc

index 94f3a4ac0be0ed69b6464a0c3b9ae309d5f3992f..be5f9913103186567966b77621eaa9e961c20eef 100644

--- a/content/browser/renderer_host/native_web_keyboard_event_android.cc

+++ b/content/browser/renderer_host/native_web_keyboard_event_android.cc

@@ -26,7 +26,8 @@ namespace content {

NativeWebKeyboardEvent::NativeWebKeyboardEvent()

: os_event(nullptr),

- skip_in_browser(false) {

+ skip_in_browser(false),

+ is_synthetic(false) {

}

NativeWebKeyboardEvent::NativeWebKeyboardEvent(

@@ -49,7 +50,8 @@ NativeWebKeyboardEvent::NativeWebKeyboardEvent(

unicode_character,

is_system_key)),

os_event(nullptr),

- skip_in_browser(false) {

+ skip_in_browser(false),

+ is_synthetic(false) {

if (!android_key_event.is_null())

os_event = NewGlobalRefForKeyEvent(android_key_event.obj());

}

@@ -58,7 +60,8 @@ NativeWebKeyboardEvent::NativeWebKeyboardEvent(

const NativeWebKeyboardEvent& other)

: WebKeyboardEvent(other),

os_event(NewGlobalRefForKeyEvent(other.os_event)),

- skip_in_browser(other.skip_in_browser) {

+ skip_in_browser(other.skip_in_browser),

+ is_synthetic(other.is_synthetic) {

}

NativeWebKeyboardEvent& NativeWebKeyboardEvent::operator=(

@@ -67,6 +70,7 @@ NativeWebKeyboardEvent& NativeWebKeyboardEvent::operator=(

os_event = NewGlobalRefForKeyEvent(other.os_event);

skip_in_browser = other.skip_in_browser;

+ is_synthetic = other.is_synthetic;

return *this;

}