content/browser/devtools/render_frame_devtools_agent_host.cc - Issue 2387353004: Delay Input.dispatchKeyEvent response until after key event ack.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/devtools/render_frame_devtools_agent_host.cc

Issue 2387353004: Delay Input.dispatchKeyEvent response until after key event ack. (Closed)

Patch Set: undo weakptr change, rebase to pull in dgozman's fix (crrev.com/437658) Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/browser/devtools/render_frame_devtools_agent_host.cc

diff --git a/content/browser/devtools/render_frame_devtools_agent_host.cc b/content/browser/devtools/render_frame_devtools_agent_host.cc

index dd1ee7ad2a1375a76a95249f3f4ea541f9807b9c..43253f6f979a19602e3abbb20b06114c04351e3e 100644

--- a/content/browser/devtools/render_frame_devtools_agent_host.cc

+++ b/content/browser/devtools/render_frame_devtools_agent_host.cc

@@ -584,6 +584,7 @@ void RenderFrameDevToolsAgentHost::OnClientDetached() {

emulation_handler_->Detached();

if (page_handler_)

page_handler_->Detached();

+ input_handler_->Detached();

service_worker_handler_->Detached();

target_handler_->Detached();

frame_trace_recorder_.reset();