chrome/browser/metrics/desktop_session_duration/desktop_session_duration_observer.h - Issue 2387353004: Delay Input.dispatchKeyEvent response until after key event ack.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/metrics/desktop_session_duration/desktop_session_duration_observer.h

Issue 2387353004: Delay Input.dispatchKeyEvent response until after key event ack. (Closed)

Patch Set: remove |is_synthetic|, fixed bug for mouse acks, add test for mouse events Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/metrics/desktop_session_duration/desktop_session_duration_observer.h

diff --git a/chrome/browser/metrics/desktop_session_duration/desktop_session_duration_observer.h b/chrome/browser/metrics/desktop_session_duration/desktop_session_duration_observer.h

index a5b8c462abad05ac384ad02e13488d1068ffd570..58e77c5dec37d3662d16b869dbb42ffac26125ee 100644

--- a/chrome/browser/metrics/desktop_session_duration/desktop_session_duration_observer.h

+++ b/chrome/browser/metrics/desktop_session_duration/desktop_session_duration_observer.h

@@ -39,6 +39,7 @@ class DesktopSessionDurationObserver

// content::RenderWidgetHost::InputEventObserver:

void OnInputEvent(const blink::WebInputEvent& event) override;

+ void OnInputEventAck(const blink::WebInputEvent& event) override {};

// content::WebContentsObserver:

void RenderViewHostChanged(content::RenderViewHost* old_host,

« no previous file with comments | « no previous file | chrome/browser/page_load_metrics/metrics_web_contents_observer.h » ('j') | content/browser/devtools/protocol/input_handler.cc » ('J')