Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(33)

Unified Diff: content/public/test/browser_test_utils.cc

Issue 2387353004: Delay Input.dispatchKeyEvent response until after key event ack. (Closed)
Patch Set: add test, address review comments about docs Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/public/test/browser_test_utils.cc
diff --git a/content/public/test/browser_test_utils.cc b/content/public/test/browser_test_utils.cc
index 3198c44524a85b4b9c200bdea2270d6497124942..b79334cce691cf94ac3c2398c9a02cb9b17d7cda 100644
--- a/content/public/test/browser_test_utils.cc
+++ b/content/public/test/browser_test_utils.cc
@@ -1529,9 +1529,13 @@ bool InputMsgWatcher::OnMessageReceived(const IPC::Message& message) {
return false;
}
+bool InputMsgWatcher::HasReceivedAck() {
+ return ack_result_ != INPUT_EVENT_ACK_STATE_UNKNOWN;
+}
+
uint32_t InputMsgWatcher::WaitForAck() {
DCHECK_CURRENTLY_ON(BrowserThread::UI);
- if (ack_result_ != INPUT_EVENT_ACK_STATE_UNKNOWN)
+ if (HasReceivedAck())
return ack_result_;
base::RunLoop run_loop;
base::AutoReset<base::Closure> reset_quit(&quit_, run_loop.QuitClosure());

Powered by Google App Engine
This is Rietveld 408576698