content/public/browser/native_web_keyboard_event.h - Issue 2387353004: Delay Input.dispatchKeyEvent response until after key event ack.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: content/public/browser/native_web_keyboard_event.h

Issue 2387353004: Delay Input.dispatchKeyEvent response until after key event ack. (Closed)

Patch Set: fix some review comments, fix a bug Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« content/browser/devtools/protocol/input_handler.cc ('K') | « content/browser/site_per_process_browsertest.cc ('k') | content/public/browser/render_widget_host.h » ('j') | content/public/browser/render_widget_host.h » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.	1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #ifndef CONTENT_PUBLIC_BROWSER_NATIVE_WEB_KEYBOARD_EVENT_H_	5 #ifndef CONTENT_PUBLIC_BROWSER_NATIVE_WEB_KEYBOARD_EVENT_H_

6 #define CONTENT_PUBLIC_BROWSER_NATIVE_WEB_KEYBOARD_EVENT_H_	6 #define CONTENT_PUBLIC_BROWSER_NATIVE_WEB_KEYBOARD_EVENT_H_

7	7

8 #include "base/compiler_specific.h"	8 #include "base/compiler_specific.h"

9 #include "base/strings/string16.h"	9 #include "base/strings/string16.h"

10 #include "build/build_config.h"	10 #include "build/build_config.h"

(...skipping 44 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
55 NativeWebKeyboardEvent& operator=(const NativeWebKeyboardEvent& event);	55 NativeWebKeyboardEvent& operator=(const NativeWebKeyboardEvent& event);

56	56

57 gfx::NativeEvent os_event;	57 gfx::NativeEvent os_event;

58	58

59 // True if the browser should ignore this event if it's not handled by the	59 // True if the browser should ignore this event if it's not handled by the

60 // renderer. This happens for RawKeyDown events that are created while IME is	60 // renderer. This happens for RawKeyDown events that are created while IME is

61 // active and is necessary to prevent backspace from doing "history back" if	61 // active and is necessary to prevent backspace from doing "history back" if

62 // it is hit in ime mode.	62 // it is hit in ime mode.

63 // Currently, it's only used by Linux and Mac ports.	63 // Currently, it's only used by Linux and Mac ports.

64 bool skip_in_browser;	64 bool skip_in_browser;

	65

	66 bool is_synthetic;
	dtapuska 2016/10/14 19:06:29 Docs? Docs? samuong 2016/10/20 23:36:18 Done. Show quoted text On 2016/10/14 19:06:29, dtapuska wrote: > Docs? Done.
65 };	67 };

66	68

67 } // namespace content	69 } // namespace content

68	70

69 #endif // CONTENT_PUBLIC_BROWSER_NATIVE_WEB_KEYBOARD_EVENT_H_	71 #endif // CONTENT_PUBLIC_BROWSER_NATIVE_WEB_KEYBOARD_EVENT_H_

OLD	NEW