Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(41)

Side by Side Diff: content/browser/site_per_process_browsertest.cc

Issue 2387353004: Delay Input.dispatchKeyEvent response until after key event ack. (Closed)
Patch Set: fix some review comments, fix a bug Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "content/browser/site_per_process_browsertest.h" 5 #include "content/browser/site_per_process_browsertest.h"
6 6
7 #include <stddef.h> 7 #include <stddef.h>
8 #include <stdint.h> 8 #include <stdint.h>
9 9
10 #include <algorithm> 10 #include <algorithm>
(...skipping 185 matching lines...) Expand 10 before | Expand all | Expand 10 after
196 return events_received_.front(); 196 return events_received_.front();
197 } 197 }
198 const std::vector<blink::WebInputEvent::Type>& events_received() { 198 const std::vector<blink::WebInputEvent::Type>& events_received() {
199 return events_received_; 199 return events_received_;
200 } 200 }
201 201
202 void OnInputEvent(const blink::WebInputEvent& event) override { 202 void OnInputEvent(const blink::WebInputEvent& event) override {
203 events_received_.push_back(event.type); 203 events_received_.push_back(event.type);
204 }; 204 };
205 205
206 void OnInputEventAck(const blink::WebInputEvent& event, bool is_synthetic)
207 override {};
208
206 private: 209 private:
207 RenderWidgetHost* host_; 210 RenderWidgetHost* host_;
208 std::vector<blink::WebInputEvent::Type> events_received_; 211 std::vector<blink::WebInputEvent::Type> events_received_;
209 212
210 DISALLOW_COPY_AND_ASSIGN(TestInputEventObserver); 213 DISALLOW_COPY_AND_ASSIGN(TestInputEventObserver);
211 }; 214 };
212 215
213 // Helper function that performs a surface hittest. 216 // Helper function that performs a surface hittest.
214 void SurfaceHitTestTestHelper( 217 void SurfaceHitTestTestHelper(
215 Shell* shell, 218 Shell* shell,
(...skipping 8117 matching lines...) Expand 10 before | Expand all | Expand 10 after
8333 // Now have the cross-process navigation commit and mark the current RFH as 8336 // Now have the cross-process navigation commit and mark the current RFH as
8334 // pending deletion. 8337 // pending deletion.
8335 cross_site_manager.WaitForNavigationFinished(); 8338 cross_site_manager.WaitForNavigationFinished();
8336 8339
8337 // Resume the navigation in the previous RFH that has just been marked as 8340 // Resume the navigation in the previous RFH that has just been marked as
8338 // pending deletion. We should not crash. 8341 // pending deletion. We should not crash.
8339 transfer_manager.WaitForNavigationFinished(); 8342 transfer_manager.WaitForNavigationFinished();
8340 } 8343 }
8341 8344
8342 } // namespace content 8345 } // namespace content
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698