Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(483)

Side by Side Diff: content/browser/site_per_process_browsertest.cc

Issue 2387353004: Delay Input.dispatchKeyEvent response until after key event ack. (Closed)
Patch Set: fix test Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "content/browser/site_per_process_browsertest.h" 5 #include "content/browser/site_per_process_browsertest.h"
6 6
7 #include <stddef.h> 7 #include <stddef.h>
8 #include <stdint.h> 8 #include <stdint.h>
9 9
10 #include <algorithm> 10 #include <algorithm>
(...skipping 190 matching lines...) Expand 10 before | Expand all | Expand 10 after
201 return events_received_.front(); 201 return events_received_.front();
202 } 202 }
203 const std::vector<blink::WebInputEvent::Type>& events_received() { 203 const std::vector<blink::WebInputEvent::Type>& events_received() {
204 return events_received_; 204 return events_received_;
205 } 205 }
206 206
207 void OnInputEvent(const blink::WebInputEvent& event) override { 207 void OnInputEvent(const blink::WebInputEvent& event) override {
208 events_received_.push_back(event.type); 208 events_received_.push_back(event.type);
209 }; 209 };
210 210
211 void OnInputEventAck(const blink::WebInputEvent& event) override {};
212
211 private: 213 private:
212 RenderWidgetHost* host_; 214 RenderWidgetHost* host_;
213 std::vector<blink::WebInputEvent::Type> events_received_; 215 std::vector<blink::WebInputEvent::Type> events_received_;
214 216
215 DISALLOW_COPY_AND_ASSIGN(TestInputEventObserver); 217 DISALLOW_COPY_AND_ASSIGN(TestInputEventObserver);
216 }; 218 };
217 219
218 // Helper function that performs a surface hittest. 220 // Helper function that performs a surface hittest.
219 void SurfaceHitTestTestHelper( 221 void SurfaceHitTestTestHelper(
220 Shell* shell, 222 Shell* shell,
(...skipping 8431 matching lines...) Expand 10 before | Expand all | Expand 10 after
8652 // hit the 20 seconds delay before https://crbug.com/657195 was fixed. 8654 // hit the 20 seconds delay before https://crbug.com/657195 was fixed.
8653 EXPECT_TRUE(NavigateToURL(shell(), page_url)); 8655 EXPECT_TRUE(NavigateToURL(shell(), page_url));
8654 EXPECT_EQ(page_url, shell()->web_contents()->GetLastCommittedURL()); 8656 EXPECT_EQ(page_url, shell()->web_contents()->GetLastCommittedURL());
8655 8657
8656 // Note: even if the test fails and for some reason, the test has not timed 8658 // Note: even if the test fails and for some reason, the test has not timed
8657 // out by this point, the test teardown code will still hit a DCHECK when it 8659 // out by this point, the test teardown code will still hit a DCHECK when it
8658 // calls AssertNoURLRequests() in the shell's URLRequestContext destructor. 8660 // calls AssertNoURLRequests() in the shell's URLRequestContext destructor.
8659 } 8661 }
8660 8662
8661 } // namespace content 8663 } // namespace content
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698