content/test/data/devtools/input_ack_tests.html - Issue 2387353004: Delay Input.dispatchKeyEvent response until after key event ack.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: content/test/data/devtools/input_ack_tests.html

Issue 2387353004: Delay Input.dispatchKeyEvent response until after key event ack. (Closed)

Patch Set: fix nits Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
(Empty)
	1 <!DOCTYPE html>

	2 <html>

	3 <body>

	4 <div id="target">click target</div>

	5 <script>

	6 var handle = function(e) {

	7 domAutomationController.setAutomationId(0);

	8 domAutomationController.send(e.constructor.name + ' listener');

	9 var start = Date.now();

	10 var end = start + 5000;

	11 while (Date.now() < end) {

	12 // spin for 5 seconds to block the key event ack
	dgozman 2016/11/21 19:14:39 This will be flaky for sure :) Do we really need i This will be flaky for sure :) Do we really need it? Let's just verify that we don't get result synchronously, then wait and get the result? samuong 2016/11/21 22:28:43 What's the best way to verify that we don't get th Show quoted text On 2016/11/21 19:14:39, dgozman wrote: > This will be flaky for sure :) Do we really need it? Let's just verify that we > don't get result synchronously, then wait and get the result? What's the best way to verify that we don't get the result synchronously? In the KeyboardEventAck, I could do something like: SendKeyEvent("rawKeyDown", 0, 13, 13, "Enter", false); ASSERT_FALSE(filter->HasReceivedAck()); But I'm not really sure the assertion does anything useful - we never ran the run loop, so we won't see the ack even if it did come in early? I could remove the assertion, but then the test starts to look a lot like the existing KeyEventSynthesizeKey test. Ideally there'd be a way to cause the JS event handler to block. I wanted to use alert() to do this, but it looks like this isn't implemented in content shell. Are there any other ways to do this? samuong 2016/11/23 00:37:47 Since I already had the browser test set up, I've Show quoted text On 2016/11/21 22:28:43, samuong wrote: > On 2016/11/21 19:14:39, dgozman wrote: > > This will be flaky for sure :) Do we really need it? Let's just verify that we > > don't get result synchronously, then wait and get the result? > > What's the best way to verify that we don't get the result synchronously? In the > KeyboardEventAck, I could do something like: > > SendKeyEvent("rawKeyDown", 0, 13, 13, "Enter", false); > ASSERT_FALSE(filter->HasReceivedAck()); > > But I'm not really sure the assertion does anything useful - we never ran the > run loop, so we won't see the ack even if it did come in early? > > I could remove the assertion, but then the test starts to look a lot like the > existing KeyEventSynthesizeKey test. > > Ideally there'd be a way to cause the JS event handler to block. I wanted to use > alert() to do this, but it looks like this isn't implemented in content shell. > Are there any other ways to do this? Since I already had the browser test set up, I've modified it to verify that the console.log notification comes before the ack and the event response, as you suggested. If you want me to convert this to a layout test, let me know.
	13 }

	14 }

	15 document.body.addEventListener('keydown', handle);

	16 document.getElementById('target').addEventListener('mousemove', handle);

	17 </script>

	18 </body>

	19 </html>

OLD	NEW

« content/browser/devtools/protocol/input_handler.cc ('K') | « content/public/test/browser_test_utils.cc ('k') | no next file » | no next file with comments »