Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(253)

Side by Side Diff: content/browser/renderer_host/render_widget_host_impl.cc

Issue 2387353004: Delay Input.dispatchKeyEvent response until after key event ack. (Closed)
Patch Set: fix nits Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "content/browser/renderer_host/render_widget_host_impl.h" 5 #include "content/browser/renderer_host/render_widget_host_impl.h"
6 6
7 #include <math.h> 7 #include <math.h>
8 8
9 #include <set> 9 #include <set>
10 #include <tuple> 10 #include <tuple>
(...skipping 2133 matching lines...) Expand 10 before | Expand all | Expand 10 after
2144 ui::LatencyInfo* latency) { 2144 ui::LatencyInfo* latency) {
2145 latency_tracker_.OnInputEvent(event, latency); 2145 latency_tracker_.OnInputEvent(event, latency);
2146 for (auto& observer : input_event_observers_) 2146 for (auto& observer : input_event_observers_)
2147 observer.OnInputEvent(event); 2147 observer.OnInputEvent(event);
2148 } 2148 }
2149 2149
2150 void RenderWidgetHostImpl::OnKeyboardEventAck( 2150 void RenderWidgetHostImpl::OnKeyboardEventAck(
2151 const NativeWebKeyboardEventWithLatencyInfo& event, 2151 const NativeWebKeyboardEventWithLatencyInfo& event,
2152 InputEventAckState ack_result) { 2152 InputEventAckState ack_result) {
2153 latency_tracker_.OnInputEventAck(event.event, &event.latency, ack_result); 2153 latency_tracker_.OnInputEventAck(event.event, &event.latency, ack_result);
2154 for (auto& input_event_observer : input_event_observers_)
2155 input_event_observer.OnInputEventAck(event.event);
2154 2156
2155 const bool processed = (INPUT_EVENT_ACK_STATE_CONSUMED == ack_result); 2157 const bool processed = (INPUT_EVENT_ACK_STATE_CONSUMED == ack_result);
2156 2158
2157 // We only send unprocessed key event upwards if we are not hidden, 2159 // We only send unprocessed key event upwards if we are not hidden,
2158 // because the user has moved away from us and no longer expect any effect 2160 // because the user has moved away from us and no longer expect any effect
2159 // of this key event. 2161 // of this key event.
2160 if (delegate_ && !processed && !is_hidden() && !event.event.skip_in_browser) { 2162 if (delegate_ && !processed && !is_hidden() && !event.event.skip_in_browser) {
2161 delegate_->HandleKeyboardEvent(event.event); 2163 delegate_->HandleKeyboardEvent(event.event);
2162 2164
2163 // WARNING: This RenderWidgetHostImpl can be deallocated at this point 2165 // WARNING: This RenderWidgetHostImpl can be deallocated at this point
2164 // (i.e. in the case of Ctrl+W, where the call to 2166 // (i.e. in the case of Ctrl+W, where the call to
2165 // HandleKeyboardEvent destroys this RenderWidgetHostImpl). 2167 // HandleKeyboardEvent destroys this RenderWidgetHostImpl).
2166 } 2168 }
2167 } 2169 }
2168 2170
2169 void RenderWidgetHostImpl::OnMouseEventAck( 2171 void RenderWidgetHostImpl::OnMouseEventAck(
2170 const MouseEventWithLatencyInfo& mouse_event, 2172 const MouseEventWithLatencyInfo& mouse_event,
2171 InputEventAckState ack_result) { 2173 InputEventAckState ack_result) {
2172 latency_tracker_.OnInputEventAck(mouse_event.event, &mouse_event.latency, 2174 latency_tracker_.OnInputEventAck(mouse_event.event, &mouse_event.latency,
2173 ack_result); 2175 ack_result);
2176 for (auto& input_event_observer : input_event_observers_)
2177 input_event_observer.OnInputEventAck(mouse_event.event);
2174 } 2178 }
2175 2179
2176 void RenderWidgetHostImpl::OnWheelEventAck( 2180 void RenderWidgetHostImpl::OnWheelEventAck(
2177 const MouseWheelEventWithLatencyInfo& wheel_event, 2181 const MouseWheelEventWithLatencyInfo& wheel_event,
2178 InputEventAckState ack_result) { 2182 InputEventAckState ack_result) {
2179 latency_tracker_.OnInputEventAck(wheel_event.event, &wheel_event.latency, 2183 latency_tracker_.OnInputEventAck(wheel_event.event, &wheel_event.latency,
2180 ack_result); 2184 ack_result);
2185 for (auto& input_event_observer : input_event_observers_)
2186 input_event_observer.OnInputEventAck(wheel_event.event);
2181 2187
2182 if (!is_hidden() && view_) { 2188 if (!is_hidden() && view_) {
2183 if (ack_result != INPUT_EVENT_ACK_STATE_CONSUMED && 2189 if (ack_result != INPUT_EVENT_ACK_STATE_CONSUMED &&
2184 delegate_ && delegate_->HandleWheelEvent(wheel_event.event)) { 2190 delegate_ && delegate_->HandleWheelEvent(wheel_event.event)) {
2185 ack_result = INPUT_EVENT_ACK_STATE_CONSUMED; 2191 ack_result = INPUT_EVENT_ACK_STATE_CONSUMED;
2186 } 2192 }
2187 view_->WheelEventAck(wheel_event.event, ack_result); 2193 view_->WheelEventAck(wheel_event.event, ack_result);
2188 } 2194 }
2189 } 2195 }
2190 2196
2191 void RenderWidgetHostImpl::OnGestureEventAck( 2197 void RenderWidgetHostImpl::OnGestureEventAck(
2192 const GestureEventWithLatencyInfo& event, 2198 const GestureEventWithLatencyInfo& event,
2193 InputEventAckState ack_result) { 2199 InputEventAckState ack_result) {
2194 latency_tracker_.OnInputEventAck(event.event, &event.latency, ack_result); 2200 latency_tracker_.OnInputEventAck(event.event, &event.latency, ack_result);
2201 for (auto& input_event_observer : input_event_observers_)
2202 input_event_observer.OnInputEventAck(event.event);
2195 2203
2196 if (view_) 2204 if (view_)
2197 view_->GestureEventAck(event.event, ack_result); 2205 view_->GestureEventAck(event.event, ack_result);
2198 } 2206 }
2199 2207
2200 void RenderWidgetHostImpl::OnTouchEventAck( 2208 void RenderWidgetHostImpl::OnTouchEventAck(
2201 const TouchEventWithLatencyInfo& event, 2209 const TouchEventWithLatencyInfo& event,
2202 InputEventAckState ack_result) { 2210 InputEventAckState ack_result) {
2203 latency_tracker_.OnInputEventAck(event.event, &event.latency, ack_result); 2211 latency_tracker_.OnInputEventAck(event.event, &event.latency, ack_result);
2212 for (auto& input_event_observer : input_event_observers_)
2213 input_event_observer.OnInputEventAck(event.event);
2204 2214
2205 if (touch_emulator_ && 2215 if (touch_emulator_ &&
2206 touch_emulator_->HandleTouchEventAck(event.event, ack_result)) { 2216 touch_emulator_->HandleTouchEventAck(event.event, ack_result)) {
2207 return; 2217 return;
2208 } 2218 }
2209 2219
2210 if (view_) 2220 if (view_)
2211 view_->ProcessAckedTouchEvent(event, ack_result); 2221 view_->ProcessAckedTouchEvent(event, ack_result);
2212 } 2222 }
2213 2223
(...skipping 287 matching lines...) Expand 10 before | Expand all | Expand 10 after
2501 // Note: We are using the origin URL provided by the sender here. It may be 2511 // Note: We are using the origin URL provided by the sender here. It may be
2502 // different from the receiver's. 2512 // different from the receiver's.
2503 file_system_file.url = 2513 file_system_file.url =
2504 GURL(storage::GetIsolatedFileSystemRootURIString( 2514 GURL(storage::GetIsolatedFileSystemRootURIString(
2505 file_system_url.origin(), filesystem_id, std::string()) 2515 file_system_url.origin(), filesystem_id, std::string())
2506 .append(register_name)); 2516 .append(register_name));
2507 } 2517 }
2508 } 2518 }
2509 2519
2510 } // namespace content 2520 } // namespace content
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698