Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(91)

Issue 2387353002: Eagerly compute closure classes (Closed)

Created:
4 years, 2 months ago by Johnni Winther
Modified:
4 years, 2 months ago
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Eagerly compute closure classes - and use elements instead of nodes as key R=sigmund@google.com Committed: https://github.com/dart-lang/sdk/commit/dd2f0a9bd07b9c9316da69f9c6f6fa05fa51609f

Patch Set 1 #

Patch Set 2 : Add comments. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+98 lines, -64 lines) Patch
M pkg/compiler/lib/src/closure.dart View 1 8 chunks +53 lines, -27 lines 0 comments Download
M pkg/compiler/lib/src/compiler.dart View 1 2 chunks +17 lines, -7 lines 0 comments Download
M pkg/compiler/lib/src/inferrer/simple_types_inferrer.dart View 2 chunks +3 lines, -3 lines 0 comments Download
M pkg/compiler/lib/src/js_backend/backend.dart View 1 chunk +8 lines, -2 lines 0 comments Download
M pkg/compiler/lib/src/js_emitter/runtime_type_generator.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M pkg/compiler/lib/src/ssa/builder.dart View 6 chunks +9 lines, -10 lines 0 comments Download
M pkg/compiler/lib/src/ssa/locals_handler.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/compiler/dart2js/serialization/model_test_helper.dart View 3 chunks +5 lines, -12 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Johnni Winther
4 years, 2 months ago (2016-10-04 10:17:30 UTC) #2
Siggi Cherem (dart-lang)
lgtm
4 years, 2 months ago (2016-10-05 16:39:44 UTC) #3
Johnni Winther
4 years, 2 months ago (2016-10-07 08:53:41 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
dd2f0a9bd07b9c9316da69f9c6f6fa05fa51609f (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698