|
|
DescriptionDo not show multiple instance of disambiguation menu for TextViewWithClickableSpans
BUG=650852
Committed: https://crrev.com/9491684515e55b01edcb3f254c8836f86b2a6aa5
Cr-Commit-Position: refs/heads/master@{#423724}
Patch Set 1 #
Messages
Total messages: 20 (14 generated)
Description was changed from ========== only show one popmenu BUG= ========== to ========== Do not show multiple instance of popmenu BUG=650852 ==========
The CQ bit was checked by gogerald@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Description was changed from ========== Do not show multiple instance of popmenu BUG=650852 ========== to ========== Do not show multiple instance of disambiguation menu BUG=650852 ==========
Patchset #1 (id:1) has been deleted
The CQ bit was checked by gogerald@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Description was changed from ========== Do not show multiple instance of disambiguation menu BUG=650852 ========== to ========== Do not show multiple instance of disambiguation menu for TextViewWithClickableSpans BUG=650852 ==========
gogerald@chromium.org changed reviewers: + tedchoc@chromium.org
Hi, PTAL,
lgtm, but what if you wanted 30 dialogs? :-)
On 2016/10/06 17:48:13, Ted C wrote: > lgtm, but what if you wanted 30 dialogs? :-) You mean 30 disambiguation menus? all clickable spans in one TextViewWithClickableSpans will be displayed in one disambiguation menu, I don't see why we want multiple identical menus, :-)
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by gogerald@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== Do not show multiple instance of disambiguation menu for TextViewWithClickableSpans BUG=650852 ========== to ========== Do not show multiple instance of disambiguation menu for TextViewWithClickableSpans BUG=650852 ==========
Message was sent while issue was closed.
Committed patchset #1 (id:20001)
Message was sent while issue was closed.
Description was changed from ========== Do not show multiple instance of disambiguation menu for TextViewWithClickableSpans BUG=650852 ========== to ========== Do not show multiple instance of disambiguation menu for TextViewWithClickableSpans BUG=650852 Committed: https://crrev.com/9491684515e55b01edcb3f254c8836f86b2a6aa5 Cr-Commit-Position: refs/heads/master@{#423724} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/9491684515e55b01edcb3f254c8836f86b2a6aa5 Cr-Commit-Position: refs/heads/master@{#423724} |