Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(634)

Issue 2387333006: Do not show multiple instance of disambiguation menu for TextViewWithClickableSpans (Closed)

Created:
4 years, 2 months ago by gogerald1
Modified:
4 years, 2 months ago
Reviewers:
Ted C
CC:
chromium-reviews, agrieve+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Do not show multiple instance of disambiguation menu for TextViewWithClickableSpans BUG=650852 Committed: https://crrev.com/9491684515e55b01edcb3f254c8836f86b2a6aa5 Cr-Commit-Position: refs/heads/master@{#423724}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -4 lines) Patch
M ui/android/java/src/org/chromium/ui/widget/TextViewWithClickableSpans.java View 3 chunks +13 lines, -4 lines 0 comments Download

Messages

Total messages: 20 (14 generated)
gogerald1
Hi, PTAL,
4 years, 2 months ago (2016-10-06 17:31:00 UTC) #10
Ted C
lgtm, but what if you wanted 30 dialogs? :-)
4 years, 2 months ago (2016-10-06 17:48:13 UTC) #11
gogerald1
On 2016/10/06 17:48:13, Ted C wrote: > lgtm, but what if you wanted 30 dialogs? ...
4 years, 2 months ago (2016-10-06 18:01:05 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2387333006/20001
4 years, 2 months ago (2016-10-06 23:04:48 UTC) #16
commit-bot: I haz the power
Committed patchset #1 (id:20001)
4 years, 2 months ago (2016-10-06 23:17:50 UTC) #18
commit-bot: I haz the power
4 years, 2 months ago (2016-10-06 23:19:57 UTC) #20
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/9491684515e55b01edcb3f254c8836f86b2a6aa5
Cr-Commit-Position: refs/heads/master@{#423724}

Powered by Google App Engine
This is Rietveld 408576698