Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(84)

Issue 2387333002: Update test expectations for unexpected successes. (Closed)

Created:
4 years, 2 months ago by Lei Zhang
Modified:
4 years, 2 months ago
Reviewers:
npm
CC:
pdfium-reviews_googlegroups.com
Target Ref:
refs/heads/master
Project:
pdfium
Visibility:
Public.

Description

Update test expectations for unexpected successes. Committed: https://pdfium.googlesource.com/pdfium/+/78c271dd9ee883f4e31e41a8adda8e615c84ad63

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -10 lines) Patch
M testing/SUPPRESSIONS View 6 chunks +5 lines, -10 lines 0 comments Download

Messages

Total messages: 12 (7 generated)
Lei Zhang
4 years, 2 months ago (2016-10-04 05:25:00 UTC) #6
npm
Yay more tests! lgtm
4 years, 2 months ago (2016-10-04 14:13:42 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2387333002/1
4 years, 2 months ago (2016-10-04 14:14:01 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://pdfium.googlesource.com/pdfium/+/78c271dd9ee883f4e31e41a8adda8e615c84ad63
4 years, 2 months ago (2016-10-04 14:14:18 UTC) #11
Lei Zhang
4 years, 2 months ago (2016-10-04 17:53:11 UTC) #12
Message was sent while issue was closed.
On 2016/10/04 14:13:42, npm wrote:
> Yay more tests! lgtm

To be clear, these tests always ran. It's just that they no longer report
"unexpected success" after this CL.

Powered by Google App Engine
This is Rietveld 408576698