components/ntp_snippets/remote/ntp_snippets_service.h - Issue 2387293009: Removes a data-dependent DCHECK().

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/ntp_snippets/remote/ntp_snippets_service.h

Issue 2387293009: Removes a data-dependent DCHECK(). (Closed)

Patch Set: merged to head Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: components/ntp_snippets/remote/ntp_snippets_service.h

diff --git a/components/ntp_snippets/remote/ntp_snippets_service.h b/components/ntp_snippets/remote/ntp_snippets_service.h

index 4690a3725141e80b7dbab2165183566a54bfcb39..16f038ceca83cf9918600171342d2ec62f8949a7 100644

--- a/components/ntp_snippets/remote/ntp_snippets_service.h

+++ b/components/ntp_snippets/remote/ntp_snippets_service.h

@@ -206,7 +206,8 @@ class NTPSnippetsService final : public ContentSuggestionsProvider,

void OnDatabaseError();

// Callback for the NTPSnippetsFetcher.

- void OnFetchFinished(NTPSnippetsFetcher::OptionalSnippets snippets);

+ void OnFetchFinished(

+ NTPSnippetsFetcher::OptionalFetchedCategories fetched_categories);

// Moves all snippets from |to_archive| into the archive of the |category|.

// It also deletes the snippets from the DB and keeps the archive reasonably