Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(68)

Unified Diff: components/ntp_snippets/remote/ntp_snippets_fetcher.h

Issue 2387293009: Removes a data-dependent DCHECK(). (Closed)
Patch Set: merged to head Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | components/ntp_snippets/remote/ntp_snippets_fetcher.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/ntp_snippets/remote/ntp_snippets_fetcher.h
diff --git a/components/ntp_snippets/remote/ntp_snippets_fetcher.h b/components/ntp_snippets/remote/ntp_snippets_fetcher.h
index df4e28ab9a757130c16bbfd66fc7af397e4c62ce..91f0915c6dafe55f572a9045c76af02c2bf10464 100644
--- a/components/ntp_snippets/remote/ntp_snippets_fetcher.h
+++ b/components/ntp_snippets/remote/ntp_snippets_fetcher.h
@@ -54,13 +54,13 @@ class NTPSnippetsFetcher : public OAuth2TokenService::Consumer,
FetchedCategory& operator=(FetchedCategory&&); // = default, in .cc
};
using FetchedCategoriesVector = std::vector<FetchedCategory>;
- using OptionalSnippets = base::Optional<FetchedCategoriesVector>;
+ using OptionalFetchedCategories = base::Optional<FetchedCategoriesVector>;
// |snippets| contains parsed snippets if a fetch succeeded. If problems
// occur, |snippets| contains no value (no actual vector in base::Optional).
// Error details can be retrieved using last_status().
using SnippetsAvailableCallback =
- base::Callback<void(OptionalSnippets snippets)>;
+ base::Callback<void(OptionalFetchedCategories fetched_categories)>;
// Enumeration listing all possible outcomes for fetch attempts. Used for UMA
// histograms, so do not change existing values. Insert new values at the end,
@@ -195,7 +195,7 @@ class NTPSnippetsFetcher : public OAuth2TokenService::Consumer,
FetchedCategoriesVector* categories);
void OnJsonParsed(std::unique_ptr<base::Value> parsed);
void OnJsonError(const std::string& error);
- void FetchFinished(OptionalSnippets snippets,
+ void FetchFinished(OptionalFetchedCategories fetched_categories,
FetchResult result,
const std::string& extra_message);
« no previous file with comments | « no previous file | components/ntp_snippets/remote/ntp_snippets_fetcher.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698