Removes a data-dependent DCHECK().

components/ntp_snippets/remote/ntp_snippets_service_unittest.cc

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/ntp_snippets/remote/ntp_snippets_service.h"
 
 #include <memory>
 #include <utility>
 #include <vector>
 
@@ skipping 1159 matching lines @@
   LoadFromJSONString(service.get(),
                      GetTestJson({GetSnippetWithUrl(
                          "http://something.com/pletely/unrelated")}));
   // The image should still be available until a restart happens.
   EXPECT_FALSE(FetchImage(service.get(), MakeArticleID(kSnippetUrl)).IsEmpty());
   ResetSnippetsService(&service);
   // After the restart, the image should be garbage collected.
   EXPECT_TRUE(FetchImage(service.get(), MakeArticleID(kSnippetUrl)).IsEmpty());
 }
 
+TEST_F(NTPSnippetsServiceTest, ShouldHandleMoreThanMaxSnippetsInResponse) {
+  auto service = MakeSnippetsService();
+
+  std::vector<std::string> suggestions;
+  for (int i = 0 ; i < service->GetMaxSnippetCountForTesting() + 1; ++i) {
+    suggestions.push_back(GetSnippetWithUrl(
+        base::StringPrintf("http://localhost/snippet-id-%d", i)));
+  }
+  LoadFromJSONString(service.get(), GetTestJson(suggestions));
+  EXPECT_THAT(service->GetSnippetsForTesting(articles_category()),
+              SizeIs(service->GetMaxSnippetCountForTesting() + 1));

[Marc Treib, 2016/10/06 15:36:13]

Is this actually the behavior we want?

[tschumann, 2016/10/06 17:57:42]

added a TODO().

+}
+
 }  // namespace ntp_snippets