third_party/WebKit/LayoutTests/bluetooth/getCharacteristics/disconnect-called-before.html - Issue 2387293008: bluetooth: Require context is connected for getCharacteristic(s)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/LayoutTests/bluetooth/getCharacteristics/disconnect-called-before.html

Issue 2387293008: bluetooth: Require context is connected for getCharacteristic(s) (Closed)

Patch Set: Address jyasskin's comments Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/bluetooth/getCharacteristics/device-disconnects-during-with-uuid.html ('k') | third_party/WebKit/LayoutTests/bluetooth/getCharacteristics/disconnect-called-before-with-uuid.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/LayoutTests/bluetooth/getCharacteristics/disconnect-called-before.html

diff --git a/third_party/WebKit/LayoutTests/bluetooth/getPrimaryService/disconnect-called-before.html b/third_party/WebKit/LayoutTests/bluetooth/getCharacteristics/disconnect-called-before.html

similarity index 50%

copy from third_party/WebKit/LayoutTests/bluetooth/getPrimaryService/disconnect-called-before.html

copy to third_party/WebKit/LayoutTests/bluetooth/getCharacteristics/disconnect-called-before.html

index b9ca3ef368690615d867e5818c54da2a887eed6e..f15789a1a86adb68876841f980514a26400a5c3e 100644

--- a/third_party/WebKit/LayoutTests/bluetooth/getPrimaryService/disconnect-called-before.html

+++ b/third_party/WebKit/LayoutTests/bluetooth/getCharacteristics/disconnect-called-before.html

@@ -10,11 +10,15 @@ promise_test(() => {

filters: [{services: ['heart_rate']}]}))

.then(device => device.gatt.connect())

.then(gattServer => {

- gattServer.disconnect();

- return assert_promise_rejects_with_message(

- gattServer.getPrimaryService('heart_rate'),

- new DOMException('GATT Server is disconnected. Cannot retrieve services.',

- 'NetworkError'));

+ return gattServer.getPrimaryService('heart_rate')

+ .then(heart_rate_service => {

+ gattServer.disconnect();

+ return assert_promise_rejects_with_message(

+ heart_rate_service.getCharacteristics(),

+ new DOMException(

+ 'GATT Server is disconnected. Cannot retrieve characteristics.',

+ 'NetworkError'));

+ });

});

-}, 'disconnect() called before getPrimaryService. Reject with NetworkError.');

+}, 'disconnect() called before getCharacteristics. Reject with NetworkError.');

</script>