Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(473)

Unified Diff: content/browser/frame_host/render_frame_host_impl.cc

Issue 2387293007: Register MediaPlayerRenderer service (Closed)
Patch Set: Added nogncheck Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | content/browser/media/android/media_player_renderer.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/frame_host/render_frame_host_impl.cc
diff --git a/content/browser/frame_host/render_frame_host_impl.cc b/content/browser/frame_host/render_frame_host_impl.cc
index ac12b2649be4ee7be55a128da4cba7668c3946e4..1edac17a1e1b877323c5d30da724e09848e01b7d 100644
--- a/content/browser/frame_host/render_frame_host_impl.cc
+++ b/content/browser/frame_host/render_frame_host_impl.cc
@@ -94,9 +94,11 @@
#include "device/geolocation/geolocation_service_context.h"
#include "device/vibration/vibration_manager_impl.h"
#include "device/wake_lock/wake_lock_service_context.h"
+#include "media/base/media_switches.h"
#include "media/mojo/interfaces/media_service.mojom.h"
#include "media/mojo/interfaces/service_factory.mojom.h"
#include "mojo/public/cpp/bindings/associated_interface_ptr.h"
+#include "mojo/public/cpp/bindings/strong_binding.h"
#include "services/shell/public/cpp/connector.h"
#include "services/shell/public/cpp/interface_provider.h"
#include "ui/accessibility/ax_tree.h"
@@ -110,6 +112,10 @@
#if defined(ENABLE_MOJO_CDM)
#include "content/browser/media/android/provision_fetcher_impl.h"
#endif
+#include "content/browser/media/android/media_player_renderer.h"
+#include "media/base/audio_renderer_sink.h"
+#include "media/base/video_renderer_sink.h"
+#include "media/mojo/services/mojo_renderer_service.h" //nogncheck
ncarter (slow) 2016/10/13 17:01:17 should be: [space][space]//[space]nogncheck
#endif
#if defined(OS_MACOSX)
@@ -211,7 +217,26 @@ RenderFrameHost* RenderFrameHost::FromID(int render_process_id,
void RenderFrameHost::AllowInjectingJavaScriptForAndroidWebView() {
g_allow_injecting_javascript = true;
}
-#endif
+
+void CreateMediaPlayerRenderer(
+ content::RenderFrameHost* render_frame_host,
+ mojo::InterfaceRequest<media::mojom::Renderer> request) {
+ std::unique_ptr<MediaPlayerRenderer> renderer =
+ base::MakeUnique<MediaPlayerRenderer>(render_frame_host);
+
+ // base::Unretained is safe here because the lifetime of the MediaPlayerRender
+ // is tied to the lifetime of the MojoRendererService.
+ media::MojoRendererService::InitiateSurfaceRequestCB surface_request_cb =
+ base::Bind(&MediaPlayerRenderer::InitiateScopedSurfaceRequest,
+ base::Unretained(renderer.get()));
+
+ media::MojoRendererService::Create(
+ nullptr, // CDMs are not supported.
+ nullptr, // Manages its own audio_sink.
+ nullptr, // Does not use video_sink. See StreamTextureWrapper instead.
+ std::move(renderer), surface_request_cb, std::move(request));
+}
+#endif // defined(OS_ANDROID)
// static
RenderFrameHostImpl* RenderFrameHostImpl::FromID(int process_id,
@@ -2188,10 +2213,16 @@ void RenderFrameHostImpl::RegisterMojoInterfaces() {
GetInterfaceRegistry()->AddInterface(
GetGlobalJavaInterfaces()
->CreateInterfaceFactory<device::VibrationManager>());
+
+ if (base::FeatureList::IsEnabled(media::kAndroidMediaPlayerRenderer)) {
+ // Creates a MojoRendererService, passing it a MediaPlayerRender.
+ GetInterfaceRegistry()->AddInterface<media::mojom::Renderer>(base::Bind(
+ &content::CreateMediaPlayerRenderer, base::Unretained(this)));
+ }
#else
GetInterfaceRegistry()->AddInterface(
base::Bind(&device::VibrationManagerImpl::Create));
-#endif
+#endif // defined(OS_ANDROID)
bool enable_web_bluetooth = base::CommandLine::ForCurrentProcess()->HasSwitch(
switches::kEnableWebBluetooth);
« no previous file with comments | « no previous file | content/browser/media/android/media_player_renderer.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698