Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(299)

Unified Diff: media/remoting/remoting_controller.cc

Issue 2387293007: Register MediaPlayerRenderer service (Closed)
Patch Set: Typo. Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « media/mojo/clients/mojo_renderer_factory.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: media/remoting/remoting_controller.cc
diff --git a/media/remoting/remoting_controller.cc b/media/remoting/remoting_controller.cc
index 3d976da51f9c670b521628c385bc5f1de41b08eb..dd38d70ff78f4760dd6b49a91de4aa2ca8c67d67 100644
--- a/media/remoting/remoting_controller.cc
+++ b/media/remoting/remoting_controller.cc
@@ -103,13 +103,14 @@ void RemotingController::OnMetadataChanged(const PipelineMetadata& metadata) {
if (!has_video_ && !has_audio_)
return;
+ // On Android, when using the MediaPlayerRenderer, |has_video_| and
+ // |has_audio_| will be true, but the respective configs will be empty.
+ // We cannot make any assumptions on the validity of configs.
if (has_video_) {
- DCHECK(metadata.video_decoder_config.IsValidConfig());
video_decoder_config_ = metadata.video_decoder_config;
is_encrypted_ |= video_decoder_config_.is_encrypted();
}
if (has_audio_) {
- DCHECK(metadata.audio_decoder_config.IsValidConfig());
audio_decoder_config_ = metadata.audio_decoder_config;
is_encrypted_ |= audio_decoder_config_.is_encrypted();
}
« no previous file with comments | « media/mojo/clients/mojo_renderer_factory.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698