Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1220)

Unified Diff: media/base/pipeline_metadata.h

Issue 2387293007: Register MediaPlayerRenderer service (Closed)
Patch Set: Typo. Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « media/base/pipeline_impl.cc ('k') | media/blink/watch_time_reporter.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: media/base/pipeline_metadata.h
diff --git a/media/base/pipeline_metadata.h b/media/base/pipeline_metadata.h
index d3030efdc80fa1e3254c59808288733114487f2c..52d037a8a60f3c4c5293eec54bf0fbf5b5700ebe 100644
--- a/media/base/pipeline_metadata.h
+++ b/media/base/pipeline_metadata.h
@@ -22,6 +22,10 @@ struct MEDIA_EXPORT PipelineMetadata {
// out-of-line copy constructor.
PipelineMetadata(const PipelineMetadata&);
+ // On Android, when using the MediaPlayerRenderer, |has_video| and |has_audio|
+ // will be true, but the respective configs will be empty.
+ // Do not make any assumptions on the validity of configs based off of the
+ // presence of audio/video.
bool has_audio;
bool has_video;
AudioDecoderConfig audio_decoder_config;
« no previous file with comments | « media/base/pipeline_impl.cc ('k') | media/blink/watch_time_reporter.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698