Register MediaPlayerRenderer service

media/blink/watch_time_reporter.cc

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "media/blink/watch_time_reporter.h"
 
 #include "base/power_monitor/power_monitor.h"
 
 namespace media {
 
@@ skipping 20 matching lines @@
                                      const GetMediaTimeCB& get_media_time_cb)
     : has_audio_(has_audio),
       has_video_(has_video),
       is_mse_(is_mse),
       is_encrypted_(is_encrypted),
       media_log_(std::move(media_log)),
       initial_video_size_(initial_video_size),
       get_media_time_cb_(get_media_time_cb) {
   DCHECK(!get_media_time_cb_.is_null());
   DCHECK(has_audio_ || has_video_);
-  if (has_video_)
-    DCHECK(!initial_video_size_.IsEmpty());
+
+  // TODO(tguilbert): For-reviewers -- Any suggested way to deal with the
+  // watchtime reporter for HLS playback? It runs into this DCHECK due to the
+  // fact that we don't know the size of the video until we start playing. I
+  // tried circumventing this by creating the watchtime reporter later, but ran
+  // into another plethora of DCHECKs instead.
+  //
+  // Considering the fact that we don't report the video anyways if it's smaller
+  // than (200, 200), I am considering just removing the DCHECK I commented
+  // below.
+  // if (has_video_)
+  //   DCHECK(!initial_video_size_.IsEmpty());
 
   if (base::PowerMonitor* pm = base::PowerMonitor::Get())
     pm->AddObserver(this);
 }
 
 WatchTimeReporter::~WatchTimeReporter() {
   // If the timer is still running, finalize immediately, this is our last
   // chance to capture metrics.
   if (reporting_timer_.IsRunning())
     MaybeFinalizeWatchTime(FinalizeTime::IMMEDIATELY);
@@ skipping 200 matching lines @@
   }
 
   // Stop the timer if this is supposed to be our last tick.
   if (is_finalizing) {
     end_timestamp_ = kNoTimestamp;
     reporting_timer_.Stop();
   }
 }
 
 }  // namespace media