Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1045)

Unified Diff: content/browser/devtools/protocol/target_handler.h

Issue 2387283003: [DevTools] Support all targets discovery in Target domain. (Closed)
Patch Set: small fix Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | content/browser/devtools/protocol/target_handler.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/devtools/protocol/target_handler.h
diff --git a/content/browser/devtools/protocol/target_handler.h b/content/browser/devtools/protocol/target_handler.h
index 09904d9f6e3751c1192e7563f2dc7fb398e548e7..9b7bcaba3a503d1dda0c9f1e7c2f37698b787e3d 100644
--- a/content/browser/devtools/protocol/target_handler.h
+++ b/content/browser/devtools/protocol/target_handler.h
@@ -35,10 +35,11 @@ class TargetHandler : public DevToolsAgentHostClient,
void UpdateFrames();
// Domain implementation.
- Response Enable();
- Response Disable();
+ Response SetDiscoverTargets(bool discover);
Response SetAutoAttach(bool auto_attach, bool wait_for_debugger_on_start);
Response SetAttachToFrames(bool value);
+ Response AttachToTarget(const std::string& target_id, bool* out_success);
+ Response DetachFromTarget(const std::string& target_id);
Response SendMessageToTarget(const std::string& target_id,
const std::string& message);
Response GetTargetInfo(const std::string& target_id,
@@ -54,7 +55,7 @@ class TargetHandler : public DevToolsAgentHostClient,
bool waiting_for_debugger);
void TargetCreatedInternal(DevToolsAgentHost* host);
void TargetRemovedInternal(DevToolsAgentHost* host);
- void AttachToTargetInternal(DevToolsAgentHost* host,
+ bool AttachToTargetInternal(DevToolsAgentHost* host,
bool waiting_for_debugger);
void DetachFromTargetInternal(DevToolsAgentHost* host);
@@ -72,7 +73,7 @@ class TargetHandler : public DevToolsAgentHostClient,
bool replaced_with_another_client) override;
std::unique_ptr<Client> client_;
- bool enabled_;
+ bool discover_;
bool auto_attach_;
bool wait_for_debugger_on_start_;
bool attach_to_frames_;
« no previous file with comments | « no previous file | content/browser/devtools/protocol/target_handler.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698