Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6)

Issue 2387273002: [css-tables] Correct cached-69296-expected.html and rebase (Closed)

Created:
4 years, 2 months ago by dgrogan
Modified:
4 years, 2 months ago
Reviewers:
Xianzhu, wangxianzhu
CC:
chromium-reviews, blink-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[css-tables] Correct cached-69296-expected.html and rebase cached-69296-expected.html was created slightly incorrectly, causing cached-69296.html to fail. BUG=613728 Committed: https://crrev.com/c093e13f12d027d3cca469664ae5e6ea3ee9e4dd Cr-Commit-Position: refs/heads/master@{#422689}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+60 lines, -30 lines) Patch
M third_party/WebKit/LayoutTests/TestExpectations View 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/paint/invalidation/table/cached-69296-expected.html View 1 chunk +0 lines, -4 lines 0 comments Download
M third_party/WebKit/LayoutTests/paint/invalidation/table/cached-69296-expected.txt View 2 chunks +60 lines, -24 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
dgrogan
Looks like for this last one, the -expected.html was wrong, not the code. See the ...
4 years, 2 months ago (2016-10-03 23:43:55 UTC) #2
Xianzhu
On 2016/10/03 23:43:55, dgrogan wrote: > Looks like for this last one, the -expected.html was ...
4 years, 2 months ago (2016-10-04 02:37:23 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2387273002/1
4 years, 2 months ago (2016-10-04 02:37:44 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-04 03:25:00 UTC) #6
commit-bot: I haz the power
4 years, 2 months ago (2016-10-04 03:28:30 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/c093e13f12d027d3cca469664ae5e6ea3ee9e4dd
Cr-Commit-Position: refs/heads/master@{#422689}

Powered by Google App Engine
This is Rietveld 408576698