Implement V8ValueTraits<T>::toV8Value conversion functions

Source/bindings/v8/ScriptPromiseResolverWithContext.h

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef ScriptPromiseResolverWithContext_h
 #define ScriptPromiseResolverWithContext_h
 
 #include "bindings/v8/NewScriptState.h"
 #include "bindings/v8/ScopedPersistent.h"
 #include "bindings/v8/ScriptPromise.h"
@@ skipping 20 matching lines @@
     WTF_MAKE_NONCOPYABLE(ScriptPromiseResolverWithContext);
 
 public:
     static PassRefPtr<ScriptPromiseResolverWithContext> create(NewScriptState* scriptState)
     {
         RefPtr<ScriptPromiseResolverWithContext> resolver = adoptRef(new ScriptPromiseResolverWithContext(scriptState));
         resolver->suspendIfNeeded();
         return resolver.release();
     }
 
+    // Anything that can be passed to ToV8Value::toV8Value can be passed to
+    // this function.
     template <typename T>
-    void resolve(T value)
+    void resolve(const T& value)
     {
         if (m_state != Pending || !executionContext() || executionContext()->activeDOMObjectsAreStopped())
             return;
         m_state = Resolving;
         NewScriptState::Scope scope(m_scriptState.get());
-        m_value.set(m_scriptState->isolate(), toV8(value));
+        m_value.set(m_scriptState->isolate(), toV8Value(value));
         if (!executionContext()->activeDOMObjectsAreSuspended())
             resolveOrRejectImmediately(&m_timer);
     }
 
+    // Anything that can be passed to ToV8Value::toV8Value can be passed to
+    // this function.
     template <typename T>
-    void reject(T value)
+    void reject(const T& value)
     {
         if (m_state != Pending || !executionContext() || executionContext()->activeDOMObjectsAreStopped())
             return;
         m_state = Rejecting;
         NewScriptState::Scope scope(m_scriptState.get());
-        m_value.set(m_scriptState->isolate(), toV8(value));
+        m_value.set(m_scriptState->isolate(), toV8Value(value));
         if (!executionContext()->activeDOMObjectsAreSuspended())
             resolveOrRejectImmediately(&m_timer);
     }
 
     // Note that an empty ScriptPromise will be returned after resolve or
     // reject is called.
     ScriptPromise promise()
     {
         return m_resolver ? m_resolver->promise() : ScriptPromise();
     }
 
     NewScriptState* scriptState() const { return m_scriptState.get(); }
 
     // ActiveDOMObject implementation.
     virtual void suspend() OVERRIDE;
     virtual void resume() OVERRIDE;
     virtual void stop() OVERRIDE;
 
 private:
     enum ResolutionState {
         Pending,
         Resolving,
         Rejecting,
         ResolvedOrRejected,
     };
 
     explicit ScriptPromiseResolverWithContext(NewScriptState*);
+    void resolveOrRejectImmediately(Timer<ScriptPromiseResolverWithContext>*);
+    void clear();
+
+    template <typename T, bool toV8ValueNeedsCreationContext>
+    struct ToV8ValueHelper;
+    template <typename T>
+    struct ToV8ValueHelper<T, true> {
+        static v8::Handle<v8::Value> toV8Value(const T& value, NewScriptState* scriptState)
+        {
+            return V8ValueTraits<T>::toV8Value(value, scriptState->context()->Global(), scriptState->isolate());
+        }
+    };
+    template <typename T>
+    struct ToV8ValueHelper<T, false> {
+        static v8::Handle<v8::Value> toV8Value(const T& value, NewScriptState* scriptState)
+        {
+            return V8ValueTraits<T>::toV8Value(value, scriptState->isolate());
+        }
+    };
 
     template <typename T>
-    v8::Handle<v8::Value> toV8(T* value)
+    v8::Handle<v8::Value> toV8Value(const T& value)
     {
-        ASSERT(m_scriptState);
-        ASSERT(!m_scriptState->contextIsEmpty());
-        return toV8NoInline(value, m_scriptState->context()->Global(), m_scriptState->isolate());
+        return ToV8ValueHelper<T, V8ValueTraits<T>::toV8ValueNeedsCreationContext>::toV8Value(value, m_scriptState.get());
     }
-    template <typename T> v8::Handle<v8::Value> toV8(PassRefPtr<T> value) { return toV8(value.get()); }
-    template <typename T> v8::Handle<v8::Value> toV8(RawPtr<T> value) { return toV8(value.get()); }
-    template <typename T, size_t inlineCapacity>
-    v8::Handle<v8::Value> toV8(const Vector<T, inlineCapacity>& value)
-    {
-        ASSERT(m_scriptState);
-        return v8ArrayNoInline(value, m_scriptState->isolate());
-    }
-    v8::Handle<v8::Value> toV8(ScriptValue value)
-    {
-        return value.v8Value();
-    }
-
-    void resolveOrRejectImmediately(Timer<ScriptPromiseResolverWithContext>*);
-    void clear();
 
     ResolutionState m_state;
     RefPtr<NewScriptState> m_scriptState;
     Timer<ScriptPromiseResolverWithContext> m_timer;
     RefPtr<ScriptPromiseResolver> m_resolver;
     ScopedPersistent<v8::Value> m_value;
 };
 
 } // namespace WebCore
 
 #endif // #ifndef ScriptPromiseResolverWithContext_h