Remove uninstall extensions command line switch

Remove uninstall extensions command line switch

BUG=351294
R=asargent@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=266225

[gpdavis, 2014-04-16 23:42:18]

Can you please review this?  As a side note, cl upload gave a presubmit error
regarding spamming the console with a printf statement in code that I did not
modify:

** Presubmit ERRORS **
These files spam the console log with printf/fprintf:
  chrome/browser/extensions/startup_helper.cc

[d.halman, 2014-04-17 00:16:59]

On 2014/04/16 23:42:18, gpdavis.chromium wrote:
> Can you please review this?  As a side note, cl upload gave a presubmit error
> regarding spamming the console with a printf statement in code that I did not
> modify:
> 
> ** Presubmit ERRORS **
> These files spam the console log with printf/fprintf:
>   chrome/browser/extensions/startup_helper.cc

I wouldn't worry about the presubmit since you didn't add any code (especially
not printf).

As far as the changes: I don't see anything you pulled out that you didn't need
to, and it appears you've grabbed everything related to the uninstall switch.
I'd say it looks good, but check with DHNishi before adding the file owners
and/or the original bug reporter.

[dhnishi (use Chromium), 2014-04-18 19:58:17]

On 2014/04/17 00:16:59, d.halman wrote:
> On 2014/04/16 23:42:18, gpdavis.chromium wrote:
> > Can you please review this?  As a side note, cl upload gave a presubmit
error
> > regarding spamming the console with a printf statement in code that I did
not
> > modify:
> > 
> > ** Presubmit ERRORS **
> > These files spam the console log with printf/fprintf:
> >   chrome/browser/extensions/startup_helper.cc
> 
> I wouldn't worry about the presubmit since you didn't add any code (especially
> not printf).
> 
> As far as the changes: I don't see anything you pulled out that you didn't
need
> to, and it appears you've grabbed everything related to the uninstall switch.
> I'd say it looks good, but check with DHNishi before adding the file owners
> and/or the original bug reporter.

Is there any actual printfs occurring? It seems weird to me that this presubmit
failure is popping up.

[gpdavis, 2014-04-22 22:56:44]

asargent@chromium.org: Please review changes in 
  chrome/browser/extensions/startup_helper.h
  chrome/browser/extensions/startup_helper.cc

sky@chromium.org: Please review changes in 
  chrome/browser/chrome_browser_main.cc


I had to use --bypass-hooks to upload this patch due to an unrelated printf
issue.  See comment six:
https://codereview.chromium.org/235483005#msg6

[sky, 2014-04-22 23:37:44]

LGTM - be sure and remove any stale includes.

[asargent_no_longer_on_chrome, 2014-04-23 21:40:17]

[Sorry for review delay]

Nice CL! One more thing to add - can you also remove the flag from 

src/chrome/common/chrome_switches.{h,cc}?


Tip: you can use codesearch.chromium.org to find (mostly) all instances of
things like this. E.g. 

https://code.google.com/p/chromium/codesearch#search/&q=switches%3A%3AkUninst...


When you've done that, upload the new version and use the "Publish+Mail
Comments" link again to let me know to take another look.

[gpdavis, 2014-04-23 21:50:21]

I went ahead and removed that switch from chrome_switches, so it's ready for you
to take a second look at.

Thanks!

[asargent_no_longer_on_chrome, 2014-04-23 22:08:22]

lgtm

You can go ahead and try submitting through the commit queue now (by hitting the
"Commit" checkbox on the review page). It's possible the same printf error that
you got on 'git cl upload' will cause the commit queue to fail - if that happens
let me know and I can submit it for you manually. 


Thanks for the patch - what bug are you going to take next? :)

[gpdavis, 2014-04-23 22:20:18]

The CQ bit was checked by gpdavis.chromium@gmail.com

[commit-bot: I haz the power, 2014-04-23 22:20:50]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/gpdavis.chromium@gmail.com/238723008/2...

[gpdavis, 2014-04-23 22:22:34]

On 2014/04/23 22:08:22, Antony Sargent wrote:
> lgtm
> 
> You can go ahead and try submitting through the commit queue now (by hitting
the
> "Commit" checkbox on the review page). It's possible the same printf error
that
> you got on 'git cl upload' will cause the commit queue to fail - if that
happens
> let me know and I can submit it for you manually. 
> 
> 
> Thanks for the patch - what bug are you going to take next? :)

Sounds good!  I went ahead and checked that box.

I'm looking into this bug at the moment:
crbug.com/259040

Are there any other bugs that you think might be good for me to take a look at?

Thanks!

[commit-bot: I haz the power, 2014-04-23 22:27:09]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-04-23 22:27:09]

Try jobs failed on following builders:
  tryserver.chromium on chromium_presubmit

[gpdavis, 2014-04-23 22:40:50]

On 2014/04/23 22:08:22, Antony Sargent wrote:
> lgtm
> 
> You can go ahead and try submitting through the commit queue now (by hitting
the
> "Commit" checkbox on the review page). It's possible the same printf error
that
> you got on 'git cl upload' will cause the commit queue to fail - if that
happens
> let me know and I can submit it for you manually. 
> 
> 
> Thanks for the patch - what bug are you going to take next? :)

Looks like you were right about that trybot failing on that printf issue.

[asargent_no_longer_on_chrome, 2014-04-24 16:02:09]

On 2014/04/23 22:40:50, gpdavis wrote:
> On 2014/04/23 22:08:22, Antony Sargent wrote:
> > lgtm
> > 
> > You can go ahead and try submitting through the commit queue now (by hitting
> the
> > "Commit" checkbox on the review page). It's possible the same printf error
> that
> > you got on 'git cl upload' will cause the commit queue to fail - if that
> happens
> > let me know and I can submit it for you manually. 
> > 
> > 
> > Thanks for the patch - what bug are you going to take next? :)
> 
> Looks like you were right about that trybot failing on that printf issue.

Looks like all the tests except the win_chromium_rel bot passed. I've
re-requested a try job on that bot since the failures seem like flaky results
unrelated to your change - if it comes back clean I'll go ahead and manually
submit.

[asargent_no_longer_on_chrome, 2014-04-25 14:21:16]

Turns out the tryjob failed again because I used 'git try' instead of 'git cl
try' (https://code.google.com/p/chromium/issues/detail?id=358556) . I'm going to
try submitting it one more time. /crossing_fingers

[asargent_no_longer_on_chrome, 2014-04-25 19:48:30]

Committed patchset #2 manually as r266225.