Issue 238723004: Paint state transition for overlay 9 patch scrollbars

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 238723004: Paint state transition for overlay 9 patch scrollbars (Closed)

Created:
6 years, 8 months ago by weiliangc

Modified:
6 years, 6 months ago

Reviewers:
sky, piman

CC:
chromium-reviews, darin-cc_chromium.org, jam, Ian Vollick, danakj, jamesr, wjmaclean, DaveMoore, kuscher1

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Visibility:
Public.

More Reviews

Description

Paint state transition for overlay 9 patch scrollbars Add functionality to paint overlay scrollbar thumbs when it's between different states (Normal/Hover/Pressed). Mainly paint linear transition state of opacity for 9 patch scrollbar resources. Blink side of change is 246293006. BUG=307578 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=276177

Patch Set 1 #

Patch Set 2 : rebase #

Patch Set 3 : get rid of win compiler error by giving pure virtual function empty impl #

Patch Set 4 : rebase #

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+129 lines, -0 lines)			Patch
M	content/child/webthemeengine_impl_default.h	View		1 chunk	+6 lines, -0 lines	0 comments	Download
M	content/child/webthemeengine_impl_default.cc	View		1 chunk	+15 lines, -0 lines	0 comments	Download
M	ui/native_theme/native_theme.h	View	1 2 3	1 chunk	+9 lines, -0 lines	0 comments	Download
M	ui/native_theme/native_theme_aura.h	View		2 chunks	+14 lines, -0 lines	0 comments	Download
M	ui/native_theme/native_theme_aura.cc	View		2 chunks	+46 lines, -0 lines	0 comments	Download
M	ui/native_theme/native_theme_base.h	View		2 chunks	+14 lines, -0 lines	0 comments	Download
M	ui/native_theme/native_theme_base.cc	View	1	1 chunk	+25 lines, -0 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/weiliangc@chromium.org/238723004/80001

6 years, 6 months ago (2014-06-10 14:27:54 UTC) #5

Message was sent while issue was closed.

Change committed as 276177

Expand Messages | Collapse Messages