Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2387223002:
Use FileDescriptorWatcher in tap_proxy.cc. (Closed)
|
Created:
4 years, 2 months ago by fdoray Modified:
4 years, 2 months ago Reviewers:
hubbe CC:
chromium-reviews, imcheng+watch_chromium.org, jasonroberts+watch_google.com, avayvod+watch_chromium.org, feature-media-reviews_chromium.org, xjz+watch_chromium.org, isheriff+watch_chromium.org, miu+watch_chromium.org Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionUse FileDescriptorWatcher in tap_proxy.cc.
FileDescriptorWatcher is a new API that replaces
MessageLoopForIO::WatchFileDescriptor.
BUG=645114
Committed: https://crrev.com/e7ee44e7643167612747acdd1bb081b4066ff89a
Cr-Commit-Position: refs/heads/master@{#423221}
Patch Set 1 #Patch Set 2 : fix build error #Messages
Total messages: 18 (13 generated)
The CQ bit was checked by fdoray@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_chromium_clobber_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
fdoray@chromium.org changed reviewers: + hubbe@chromium.org
PTAL
Description was changed from ========== Use FileDescriptorWatcher in tab_proxy.cc. FileDescriptorWatcher is a new API that replaces MessageLoopForIO::WatchFileDescriptor. BUG=645114 ========== to ========== Use FileDescriptorWatcher in tap_proxy.cc. FileDescriptorWatcher is a new API that replaces MessageLoopForIO::WatchFileDescriptor. BUG=645114 ==========
The CQ bit was checked by fdoray@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
lgtm
The CQ bit was checked by fdoray@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== Use FileDescriptorWatcher in tap_proxy.cc. FileDescriptorWatcher is a new API that replaces MessageLoopForIO::WatchFileDescriptor. BUG=645114 ========== to ========== Use FileDescriptorWatcher in tap_proxy.cc. FileDescriptorWatcher is a new API that replaces MessageLoopForIO::WatchFileDescriptor. BUG=645114 ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
Message was sent while issue was closed.
Description was changed from ========== Use FileDescriptorWatcher in tap_proxy.cc. FileDescriptorWatcher is a new API that replaces MessageLoopForIO::WatchFileDescriptor. BUG=645114 ========== to ========== Use FileDescriptorWatcher in tap_proxy.cc. FileDescriptorWatcher is a new API that replaces MessageLoopForIO::WatchFileDescriptor. BUG=645114 Committed: https://crrev.com/e7ee44e7643167612747acdd1bb081b4066ff89a Cr-Commit-Position: refs/heads/master@{#423221} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/e7ee44e7643167612747acdd1bb081b4066ff89a Cr-Commit-Position: refs/heads/master@{#423221} |
