Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(805)

Unified Diff: net/websockets/websocket_extension_parser_test.cc

Issue 23872029: Implement WebSocketExtensionParser (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: net/websockets/websocket_extension_parser_test.cc
diff --git a/net/websockets/websocket_extension_parser_test.cc b/net/websockets/websocket_extension_parser_test.cc
new file mode 100644
index 0000000000000000000000000000000000000000..c24e03e588ebe490d53b5317647cc47423411a56
--- /dev/null
+++ b/net/websockets/websocket_extension_parser_test.cc
@@ -0,0 +1,142 @@
+// Copyright 2013 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "net/websockets/websocket_extension_parser.h"
+
+#include <string>
+
+#include "net/websockets/websocket_extension.h"
+#include "testing/gtest/include/gtest/gtest.h"
+
+namespace net {
+
+namespace {
+
+TEST(WebSocketExtensionParserTest, ParseEmpty) {
+ WebSocketExtensionParser parser;
+ parser.Parse("", 0);
+
+ EXPECT_TRUE(parser.has_error());
+ EXPECT_TRUE(parser.extensions().empty());
+}
+
+TEST(WebSocketExtensionParserTest, ParseSimple) {
+ WebSocketExtensionParser parser;
+ std::vector<WebSocketExtension> expected;
+ expected.push_back(WebSocketExtension("foo"));
+
+ parser.Parse("foo");
+
+ ASSERT_FALSE(parser.has_error());
+ EXPECT_EQ(expected, parser.extensions());
+}
+
+TEST(WebSocketExtensionParserTest, ParseOneExtensionWithOneParamWithoutValue) {
+ WebSocketExtensionParser parser;
+ WebSocketExtension foo("foo");
+ foo.Add(WebSocketExtension::Parameter("bar"));
+ std::vector<WebSocketExtension> expected;
+ expected.push_back(foo);
+
+ parser.Parse("\tfoo ; bar");
+
+ ASSERT_FALSE(parser.has_error());
+ EXPECT_EQ(expected, parser.extensions());
+}
+
+TEST(WebSocketExtensionParserTest, ParseOneExtensionWithOneParamWithValue) {
+ WebSocketExtensionParser parser;
+ WebSocketExtension foo("foo");
+ foo.Add(WebSocketExtension::Parameter("bar", "baz"));
+ std::vector<WebSocketExtension> expected;
+ expected.push_back(foo);
+
+ parser.Parse("foo ; bar= baz");
+
+ ASSERT_FALSE(parser.has_error());
+ EXPECT_EQ(expected, parser.extensions());
+}
+
+TEST(WebSocketExtensionParserTest, ParseOneExtensionWithParams) {
+ WebSocketExtensionParser parser;
+ WebSocketExtension foo("foo");
+ foo.Add(WebSocketExtension::Parameter("bar", "baz"));
+ foo.Add(WebSocketExtension::Parameter("hoge", "fuga"));
+ std::vector<WebSocketExtension> expected;
+ expected.push_back(foo);
+
+ parser.Parse("foo ; bar= baz;\t \thoge\r\n\t=fuga");
+
+ ASSERT_FALSE(parser.has_error());
+ EXPECT_EQ(expected, parser.extensions());
+}
+
+TEST(WebSocketExtensionParserTest, ParseMultipleExtensions) {
+ WebSocketExtensionParser parser;
+ WebSocketExtension foo("foo"), baz("baz"), hoge("hoge");
+ foo.Add(WebSocketExtension::Parameter("bar"));
+ hoge.Add(WebSocketExtension::Parameter("fuga", "piyo"));
+ std::vector<WebSocketExtension> expected;
+ expected.push_back(foo);
+ expected.push_back(baz);
+ expected.push_back(hoge);
+
+ parser.Parse("foo ; bar baz\thoge\r\n ;fuga=piyo");
+
+ ASSERT_FALSE(parser.has_error());
+ EXPECT_EQ(expected, parser.extensions());
+}
+
+TEST(WebSocketExtensionParserTest, InvalidPatterns) {
+ const char* patterns[] = {
+ "foo ", // trailing space
+ "fo\ao", // control in extension name
+ "fo\x01o", // control in extension name
+ "fo<o", // separator in extension name
+ "foo/", // separator in extension name
+ ";bar", // empty extension name
+ "foo; b\ar", // control in parameter name
+ "foo; b\x7fr", // control in parameter name
+ "foo; b[r", // separator in parameter name
+ "foo; ba:", // separator in parameter name
+ "foo; =baz", // empty parameter name
+ "foo; bar=", // empty parameter value
+ "foo; =", // empty parameter name and value
+ "foo; bar=b\x02z", // control in parameter value
+ "foo; bar=b@z", // separator in parameter value
+ "foo; bar=b\\z", // separator in parameter value
+ "foo; bar=b?z", // separator in parameter value
+ "\"foo\"", // quoted extension name
+ "foo; \"bar\"", // quoted parameter name
+ "foo; bar=\"\a2\"", // control in quoted parameter value
+ "foo; bar=\"b@z\"", // separator in quoted parameter value
+ "foo; bar=\"b\\\\z\"", // separator in quoted parameter value
+ "foo; bar=\"\"", // quoted emptyparameter value
+ "foo\r\nbar", // CRNL not followed by a space
+ };
+
+ for (size_t i = 0; i < arraysize(patterns); ++i) {
+ WebSocketExtensionParser parser;
+ parser.Parse(patterns[i]);
+ EXPECT_TRUE(parser.has_error());
+ EXPECT_TRUE(parser.extensions().empty());
+ }
+}
+
+TEST(WebSocketExtensionParserTest, QuotedParameterValue) {
+ WebSocketExtensionParser parser;
+ WebSocketExtension foo("foo");
+ foo.Add(WebSocketExtension::Parameter("bar", "baz"));
+ std::vector<WebSocketExtension> expected;
+ expected.push_back(foo);
+
+ parser.Parse("foo; bar=\"ba\\z\"");
+
+ ASSERT_FALSE(parser.has_error());
+ EXPECT_EQ(expected, parser.extensions());
+}
+
+} // namespace
+
+} // namespace net
« net/websockets/websocket_extension_parser.cc ('K') | « net/websockets/websocket_extension_parser.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698