Implement WebSocketExtensionParser

net/websockets/websocket_extension.h

+// Copyright 2013 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef NET_WEBSOCKETS_WEBSOCKET_EXTENSION_H_
+#define NET_WEBSOCKETS_WEBSOCKET_EXTENSION_H_
+
+#include <string>
+#include <vector>
+
+#include "net/base/net_export.h"
+
+namespace net {
+
+// A WebSocketExtension instance represents a WebSocket extension specified
+// in RFC6455.
+class NET_EXPORT_PRIVATE WebSocketExtension {
+ public:
+  // Note that RFC6455 does not allow a parameter with an empty value.
+  class Parameter {
+   public:
+    // Construct a parameter which does not have a value.
+    explicit Parameter(const std::string& name);
+    // Construct a parameter with a non-empty value.
+    Parameter(const std::string& name, const std::string& value);
+
+    bool HasValue() const { return !value_.empty(); }
+    const std::string& name() const { return name_; }
+    const std::string& value() const { return value_; }
+
+    bool operator == (const Parameter& other) const {

[Adam Rice, 2013/09/17 04:30:33]

There should be no spaces around the == signs.

Also, the style guide is pretty negative about operator overloading:
http://google-styleguide.googlecode.com/svn/trunk/cppguide.xml?showone=Operat...
and so you should avoid it unless you explicitly require it.

[yhirano, 2013/09/17 06:03:31]

Done.

+      return name_ == other.name_ && value_ == other.value_;
+    }
+

[Adam Rice, 2013/09/17 04:30:33]

Please add a comment that you are using the compiler-generated copy constructor
and assignment operator.

[yhirano, 2013/09/17 06:03:31]

Done.

+   private:
+    std::string name_;
+    std::string value_;
+  };
+
+  explicit WebSocketExtension(const std::string& name);
+  ~WebSocketExtension();
+
+  void Add(const Parameter& parameter) { parameters_.push_back(parameter); }
+  const std::string& name() const { return name_; }
+  const std::vector<Parameter>& parameters() const { return parameters_; }
+
+  bool operator == (const WebSocketExtension& other) const {
+    return name_ == other.name_ && parameters_ == other.parameters_;
+  }
+
+ private:
+  std::string name_;
+  std::vector<Parameter> parameters_;
+};
+
+}  // namespace net
+
+#endif  // NET_WEBSOCKETS_WEBSOCKET_EXTENSION_H_