Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(179)

Issue 23872027: Add Contains(), at(), and a constructor with raw addresses to UniqueSet<T> and Unique<T>. (Closed)

Created:
7 years, 3 months ago by titzer
Modified:
7 years, 3 months ago
Reviewers:
Toon Verwaest
CC:
v8-dev
Visibility:
Public.

Description

Add Contains(), at(), and a constructor with raw addresses to UniqueSet<T> and Unique<T>. BUG= R=verwaest@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=16716

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+92 lines, -6 lines) Patch
M src/unique.h View 7 chunks +24 lines, -6 lines 1 comment Download
M test/cctest/test-unique.cc View 1 chunk +68 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
titzer
7 years, 3 months ago (2013-09-13 11:09:48 UTC) #1
Toon Verwaest
lgtm with nit https://codereview.chromium.org/23872027/diff/1/src/unique.h File src/unique.h (right): https://codereview.chromium.org/23872027/diff/1/src/unique.h#newcode155 src/unique.h:155: // TODO(titzer): use binary search for ...
7 years, 3 months ago (2013-09-13 11:20:48 UTC) #2
titzer
On 2013/09/13 11:20:48, Toon Verwaest wrote: > lgtm with nit > > https://codereview.chromium.org/23872027/diff/1/src/unique.h > File ...
7 years, 3 months ago (2013-09-13 12:27:05 UTC) #3
titzer
7 years, 3 months ago (2013-09-13 12:36:56 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 manually as r16716 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698