Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(64)

Side by Side Diff: chromeos/network/network_connection_handler.cc

Issue 23872021: Use Name not SSID in CopyIdentifyingProperties (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Rebase Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « chrome/browser/chromeos/options/wifi_config_view.cc ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2013 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chromeos/network/network_connection_handler.h" 5 #include "chromeos/network/network_connection_handler.h"
6 6
7 #include "base/bind.h" 7 #include "base/bind.h"
8 #include "base/command_line.h" 8 #include "base/command_line.h"
9 #include "base/json/json_reader.h" 9 #include "base/json/json_reader.h"
10 #include "chromeos/chromeos_switches.h" 10 #include "chromeos/chromeos_switches.h"
(...skipping 434 matching lines...) Expand 10 before | Expand all | Expand 10 after
445 client_cert::SetShillProperties(client_cert_type, 445 client_cert::SetShillProperties(client_cert_type,
446 cert_loader_->tpm_token_slot(), 446 cert_loader_->tpm_token_slot(),
447 cert_loader_->tpm_user_pin(), 447 cert_loader_->tpm_user_pin(),
448 pkcs11_id.empty() ? NULL : &pkcs11_id, 448 pkcs11_id.empty() ? NULL : &pkcs11_id,
449 &config_properties); 449 &config_properties);
450 } 450 }
451 } 451 }
452 452
453 if (!config_properties.empty()) { 453 if (!config_properties.empty()) {
454 NET_LOG_EVENT("Configuring Network", service_path); 454 NET_LOG_EVENT("Configuring Network", service_path);
455 if (shill_property_util::CopyIdentifyingProperties(service_properties, 455 network_configuration_handler_->SetProperties(
456 &config_properties)) { 456 service_path,
457 network_configuration_handler_->SetProperties( 457 config_properties,
458 service_path, 458 base::Bind(&NetworkConnectionHandler::CallShillConnect,
459 config_properties, 459 AsWeakPtr(),
460 base::Bind(&NetworkConnectionHandler::CallShillConnect, 460 service_path),
461 AsWeakPtr(), 461 base::Bind(&NetworkConnectionHandler::HandleConfigurationFailure,
462 service_path), 462 AsWeakPtr(),
463 base::Bind(&NetworkConnectionHandler::HandleConfigurationFailure, 463 service_path));
464 AsWeakPtr(), 464 return;
465 service_path));
466 return;
467 }
468 NET_LOG_ERROR("Shill dictionary is missing some relevant entries",
469 service_path);
470 } 465 }
471 466
472 // Otherwise, we probably still need to configure the network since 467 // Otherwise, we probably still need to configure the network since
473 // 'Connectable' is false. If |check_error_state| is true, signal an 468 // 'Connectable' is false. If |check_error_state| is true, signal an
474 // error, otherwise attempt to connect to possibly gain additional error 469 // error, otherwise attempt to connect to possibly gain additional error
475 // state from Shill (or in case 'Connectable' is improperly unset). 470 // state from Shill (or in case 'Connectable' is improperly unset).
476 if (check_error_state) 471 if (check_error_state)
477 ErrorCallbackForPendingRequest(service_path, kErrorConfigurationRequired); 472 ErrorCallbackForPendingRequest(service_path, kErrorConfigurationRequired);
478 else 473 else
479 CallShillConnect(service_path); 474 CallShillConnect(service_path);
(...skipping 168 matching lines...) Expand 10 before | Expand all | Expand 10 after
648 643
649 void NetworkConnectionHandler::HandleShillDisconnectSuccess( 644 void NetworkConnectionHandler::HandleShillDisconnectSuccess(
650 const std::string& service_path, 645 const std::string& service_path,
651 const base::Closure& success_callback) { 646 const base::Closure& success_callback) {
652 NET_LOG_EVENT("Disconnect Request Sent", service_path); 647 NET_LOG_EVENT("Disconnect Request Sent", service_path);
653 if (!success_callback.is_null()) 648 if (!success_callback.is_null())
654 success_callback.Run(); 649 success_callback.Run();
655 } 650 }
656 651
657 } // namespace chromeos 652 } // namespace chromeos
OLDNEW
« no previous file with comments | « chrome/browser/chromeos/options/wifi_config_view.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698