pkg/mdv/lib/src/template_iterator.dart - Issue 23872008: Reapply "Make LinkedHashMap also have a factory constructor and be customizable""

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/mdv/lib/src/template_iterator.dart

Issue 23872008: Reapply "Make LinkedHashMap also have a factory constructor and be customizable"" (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Created 7 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: pkg/mdv/lib/src/template_iterator.dart

diff --git a/pkg/mdv/lib/src/template_iterator.dart b/pkg/mdv/lib/src/template_iterator.dart

index 6c87a42a292d5857171984d7718625e936889447..84581657b87902afc5084e1aa70de93e8540357e 100644

--- a/pkg/mdv/lib/src/template_iterator.dart

+++ b/pkg/mdv/lib/src/template_iterator.dart

@@ -344,9 +344,7 @@ class _TemplateIterator {

return;

}

- // TODO(jmesserly): IdentityMap matches JS semantics, but it's O(N) right

- // now. See http://dartbug.com/4161.

- var instanceCache = new IdentityMap();

+ var instanceCache = new HashMap(equals: identical);

var removeDelta = 0;

for (var splice in splices) {

for (int i = 0; i < splice.removedCount; i++) {

« no previous file with comments | « pkg/analyzer_experimental/lib/src/generated/java_core.dart ('k') | pkg/serialization/lib/src/reader_writer.dart » ('j') | no next file with comments »