Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(15)

Issue 2387193002: [Launcher Shortcuts] Report shortcut usage (Closed)

Created:
4 years, 2 months ago by Theresa
Modified:
4 years, 2 months ago
Reviewers:
Ted C
CC:
chromium-reviews, agrieve+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Launcher Shortcuts] Report shortcut usage Call ShortcutManager#reportShortcutUsed when the user seelcts a shortcut or completes an action that is equivalent to selecting the shortcut. BUG=652023 Committed: https://crrev.com/4c7e8bf23fca6725154e0215a69ee44ac8223408 Cr-Commit-Position: refs/heads/master@{#422539}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -1 line) Patch
M chrome/android/java/src/org/chromium/chrome/browser/ChromeTabbedActivity.java View 7 chunks +30 lines, -1 line 0 comments Download

Messages

Total messages: 8 (3 generated)
Theresa
ptal
4 years, 2 months ago (2016-10-03 20:23:20 UTC) #2
Ted C
lgtm
4 years, 2 months ago (2016-10-03 20:38:04 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2387193002/1
4 years, 2 months ago (2016-10-03 20:39:05 UTC) #5
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/4c7e8bf23fca6725154e0215a69ee44ac8223408 Cr-Commit-Position: refs/heads/master@{#422539}
4 years, 2 months ago (2016-10-03 21:34:21 UTC) #7
commit-bot: I haz the power
4 years, 2 months ago (2016-10-03 21:34:26 UTC) #8
Message was sent while issue was closed.
Failed to apply the patch.
On branch working_branch
Your branch is up-to-date with 'origin/refs/pending/heads/master'.
nothing to commit, working tree clean

Powered by Google App Engine
This is Rietveld 408576698