Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(89)

Issue 2387173003: [IC] Delete unused AddessIsOptimizedCode function. (Closed)

Created:
4 years, 2 months ago by Franzi
Modified:
4 years, 2 months ago
Reviewers:
mvstanton
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[IC] Delete unused AddessIsOptimizedCode function. BUG= Committed: https://crrev.com/54fb438e882996b2a75ded1fc27e2b5521e7aa1b Cr-Commit-Position: refs/heads/master@{#39956}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -8 lines) Patch
M src/ic/ic.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/ic/ic.cc View 1 chunk +0 lines, -7 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 12 (7 generated)
Franzi
Hi Mike, I was trying to understand ic.cc and came across a few unused variables. ...
4 years, 2 months ago (2016-10-04 14:04:14 UTC) #6
mvstanton
Fantastic - I believe this predicate was used in the past to avoid patching in ...
4 years, 2 months ago (2016-10-04 14:24:32 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2387173003/1
4 years, 2 months ago (2016-10-04 14:25:55 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-04 14:28:18 UTC) #10
commit-bot: I haz the power
4 years, 2 months ago (2016-10-04 14:28:43 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/54fb438e882996b2a75ded1fc27e2b5521e7aa1b
Cr-Commit-Position: refs/heads/master@{#39956}

Powered by Google App Engine
This is Rietveld 408576698