[MD Settings][People] Disables profile name field for legacy supervised users.

[MD Settings][People] Disables profile name field for legacy supervised users.

BUG=642994
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/4bbdd8e5ac806f6aca1166ea36bb55b8b5bbde48
Cr-Commit-Position: refs/heads/master@{#422771}

[Moe, 2016-10-03 18:41:56]

Description was changed from

==========
[MD Settings][People] Disables profile name field for legacy supervised users.

BUG=642994
==========

to

==========
[MD Settings][People] Disables profile name field for legacy supervised users.

BUG=642994
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[Moe, 2016-10-03 18:42:09]

The CQ bit was checked by mahmadi@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-03 18:42:41]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Moe, 2016-10-03 19:36:29]

mahmadi@chromium.org changed reviewers:
+ tommycli@chromium.org

[Moe, 2016-10-03 19:36:30]

Hi Tommy, Please review this CL.

[commit-bot: I haz the power, 2016-10-03 20:33:07]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-03 20:33:08]

Dry run: This issue passed the CQ dry run.

[tommycli, 2016-10-03 20:37:23]

lgtm except

https://codereview.chromium.org/2387173002/diff/1/chrome/browser/resources/se...
File chrome/browser/resources/settings/people_page/manage_profile.js (right):

https://codereview.chromium.org/2387173002/diff/1/chrome/browser/resources/se...
chrome/browser/resources/settings/people_page/manage_profile.js:90:
disableProfileName_: function(syncStatus) {
isProfileNameDisabled_

https://codereview.chromium.org/2387173002/diff/1/chrome/test/data/webui/sett...
File chrome/test/data/webui/settings/people_page_manage_profile_test.js (right):

https://codereview.chromium.org/2387173002/diff/1/chrome/test/data/webui/sett...
chrome/test/data/webui/settings/people_page_manage_profile_test.js:101:
assertTrue(!!nameField.disabled);
Can we separate out the legacy supervised users into a separate test?

Otherwise this test simulataneously tests: 1. That the field is disabled and 2.
Changing the field and firing a change event...

It just seems... kind of schizophrenic to have the same test do both :D

[Moe, 2016-10-03 22:26:25]

The CQ bit was checked by mahmadi@chromium.org to run a CQ dry run

[Moe, 2016-10-03 22:26:43]

https://codereview.chromium.org/2387173002/diff/1/chrome/browser/resources/se...
File chrome/browser/resources/settings/people_page/manage_profile.js (right):

https://codereview.chromium.org/2387173002/diff/1/chrome/browser/resources/se...
chrome/browser/resources/settings/people_page/manage_profile.js:90:
disableProfileName_: function(syncStatus) {
On 2016/10/03 20:37:22, tommycli wrote:
> isProfileNameDisabled_

Done.

https://codereview.chromium.org/2387173002/diff/1/chrome/test/data/webui/sett...
File chrome/test/data/webui/settings/people_page_manage_profile_test.js (right):

https://codereview.chromium.org/2387173002/diff/1/chrome/test/data/webui/sett...
chrome/test/data/webui/settings/people_page_manage_profile_test.js:101:
assertTrue(!!nameField.disabled);
On 2016/10/03 20:37:22, tommycli wrote:
> Can we separate out the legacy supervised users into a separate test?
> 
> Otherwise this test simulataneously tests: 1. That the field is disabled and
2.
> Changing the field and firing a change event...
> 
> It just seems... kind of schizophrenic to have the same test do both :D

fair enough! done.

[commit-bot: I haz the power, 2016-10-03 22:27:30]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-03 23:47:52]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-03 23:47:52]

Dry run: This issue passed the CQ dry run.

[Moe, 2016-10-04 13:27:48]

The CQ bit was checked by mahmadi@chromium.org

[Moe, 2016-10-04 13:27:48]

The patchset sent to the CQ was uploaded after l-g-t-m from
tommycli@chromium.org
Link to the patchset: https://codereview.chromium.org/2387173002/#ps20001
(title: "Addressed comments")

[commit-bot: I haz the power, 2016-10-04 13:28:11]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-04 13:33:27]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-10-04 13:34:57]

Description was changed from

==========
[MD Settings][People] Disables profile name field for legacy supervised users.

BUG=642994
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
[MD Settings][People] Disables profile name field for legacy supervised users.

BUG=642994
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/4bbdd8e5ac806f6aca1166ea36bb55b8b5bbde48
Cr-Commit-Position: refs/heads/master@{#422771}
==========

[commit-bot: I haz the power, 2016-10-04 13:34:58]

Patchset 2 (id:??) landed as
https://crrev.com/4bbdd8e5ac806f6aca1166ea36bb55b8b5bbde48
Cr-Commit-Position: refs/heads/master@{#422771}