Report all flakes reported to issue tracker also to FindIt

Report all flakes reported to issue tracker also to FindIt

R=stgao@chromium.org
BUG=652341
Committed: https://chromium.googlesource.com/infra/infra/+/4bd270034f02650027a8f3b5ab153823c30e5bfa

[Sergiy Byelozyorov, 2016-10-03 17:49:33]

This is still missing tests, but PTAL at this early version so that I won't have
to write tests for the wrong code :-).

[stgao, 2016-10-03 19:24:35]

lgtm

Many thanks for this quick CL!

Please hold a bit for deploying a new version with this change, if you don't
want to see errors on your app :)
On Findit side, my CL for the api is not committed nor deployed yet, but that
should be done in the next two days and I will ping you when it's done.

https://codereview.chromium.org/2387153002/diff/20001/appengine/chromium_try_...
File appengine/chromium_try_flakes/findit/findit.py (right):

https://codereview.chromium.org/2387153002/diff/20001/appengine/chromium_try_...
appengine/chromium_try_flakes/findit/findit.py:87: 'step_name': occurrence.name
To double check:
is it the original step name as shown on the buildbot build page, or the step
name after normalization by test_results.appspot.com?

I assumed it is the original step name, but not entirely sure.

[Sergiy Byelozyorov, 2016-10-04 08:58:22]

https://codereview.chromium.org/2387153002/diff/20001/appengine/chromium_try_...
File appengine/chromium_try_flakes/findit/findit.py (right):

https://codereview.chromium.org/2387153002/diff/20001/appengine/chromium_try_...
appengine/chromium_try_flakes/findit/findit.py:87: 'step_name': occurrence.name
On 2016/10/03 19:24:35, stgao (slow) wrote:
> To double check:
> is it the original step name as shown on the buildbot build page, or the step
> name after normalization by test_results.appspot.com?
> 
> I assumed it is the original step name, but not entirely sure.

This is original step name. The normalized step name for flaky steps is
contained in occurrence.flake.

[Sergiy Byelozyorov, 2016-10-04 08:58:37]

On 2016/10/03 19:24:35, stgao (slow) wrote:
> lgtm
> 
> Many thanks for this quick CL!
> 
> Please hold a bit for deploying a new version with this change, if you don't
> want to see errors on your app :)
> On Findit side, my CL for the api is not committed nor deployed yet, but that
> should be done in the next two days and I will ping you when it's done.

Sure. I was planning to wait for this anyway.

> 
>
https://codereview.chromium.org/2387153002/diff/20001/appengine/chromium_try_...
> File appengine/chromium_try_flakes/findit/findit.py (right):
> 
>
https://codereview.chromium.org/2387153002/diff/20001/appengine/chromium_try_...
> appengine/chromium_try_flakes/findit/findit.py:87: 'step_name':
occurrence.name
> To double check:
> is it the original step name as shown on the buildbot build page, or the step
> name after normalization by test_results.appspot.com?
> 
> I assumed it is the original step name, but not entirely sure.

[Sergiy Byelozyorov, 2016-10-04 11:01:34]

Patchset #3 (id:30001) has been deleted

[Sergiy Byelozyorov, 2016-10-04 11:03:01]

Refactored endpoints code and added tests. PTAL

[stgao, 2016-10-05 00:28:48]

lgtm with nits

The corresponding change on Findit side is
https://codereview.chromium.org/2397603002/.
The testing version is https://stgao-dot-findit-for-me.appspot.com

If lg2med, I will commit and deploy a new version of Findit.

https://codereview.chromium.org/2387153002/diff/20001/appengine/chromium_try_...
File appengine/chromium_try_flakes/findit/findit.py (right):

https://codereview.chromium.org/2387153002/diff/20001/appengine/chromium_try_...
appengine/chromium_try_flakes/findit/findit.py:87: 'step_name': occurrence.name
On 2016/10/04 08:58:22, Sergiy Byelozyorov wrote:
> On 2016/10/03 19:24:35, stgao (slow) wrote:
> > To double check:
> > is it the original step name as shown on the buildbot build page, or the
step
> > name after normalization by test_results.appspot.com?
> > 
> > I assumed it is the original step name, but not entirely sure.
> 
> This is original step name. The normalized step name for flaky steps is
> contained in occurrence.flake.

Acknowledged.

https://codereview.chromium.org/2387153002/diff/50001/appengine/chromium_try_...
File appengine/chromium_try_flakes/endpoints/endpoints.py (right):

https://codereview.chromium.org/2387153002/diff/50001/appengine/chromium_try_...
appengine/chromium_try_flakes/endpoints/endpoints.py:48: http,
'https://www.googleapis.com/auth/userinfo.email')
nit: make this a constant var

https://codereview.chromium.org/2387153002/diff/50001/appengine/chromium_try_...
appengine/chromium_try_flakes/endpoints/endpoints.py:60: delay = 2**(tries-1)
nit: space before and after "-". And "**" too?

https://codereview.chromium.org/2387153002/diff/50001/appengine/chromium_try_...
appengine/chromium_try_flakes/endpoints/endpoints.py:81:
time.sleep(2**(tries-1))
same here.

[Sergiy Byelozyorov, 2016-10-05 13:05:25]

https://codereview.chromium.org/2387153002/diff/50001/appengine/chromium_try_...
File appengine/chromium_try_flakes/endpoints/endpoints.py (right):

https://codereview.chromium.org/2387153002/diff/50001/appengine/chromium_try_...
appengine/chromium_try_flakes/endpoints/endpoints.py:48: http,
'https://www.googleapis.com/auth/userinfo.email')
On 2016/10/05 00:28:47, stgao (slow) wrote:
> nit: make this a constant var

Done.

https://codereview.chromium.org/2387153002/diff/50001/appengine/chromium_try_...
appengine/chromium_try_flakes/endpoints/endpoints.py:60: delay = 2**(tries-1)
On 2016/10/05 00:28:47, stgao (slow) wrote:
> nit: space before and after "-". And "**" too?

Done.

https://codereview.chromium.org/2387153002/diff/50001/appengine/chromium_try_...
appengine/chromium_try_flakes/endpoints/endpoints.py:81:
time.sleep(2**(tries-1))
On 2016/10/05 00:28:47, stgao (slow) wrote:
> same here.

Done.

[Sergiy Byelozyorov, 2016-10-05 13:05:29]

The CQ bit was checked by sergiyb@chromium.org

[Sergiy Byelozyorov, 2016-10-05 13:05:29]

The patchset sent to the CQ was uploaded after l-g-t-m from stgao@chromium.org
Link to the patchset: https://codereview.chromium.org/2387153002/#ps70001
(title: "Addressed comments")

[commit-bot: I haz the power, 2016-10-05 13:05:34]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-05 13:05:35]

COMMIT=false detected. CQ is abandoning the patch.

[Sergiy Byelozyorov, 2016-10-05 13:06:18]

Description was changed from

==========
Report all flakes reported to issue tracker also to FindIt

COMMIT=false (this is still missing tests)

R=stgao@chromium.org
BUG=652341
==========

to

==========
Report all flakes reported to issue tracker also to FindIt

R=stgao@chromium.org
BUG=652341
==========

[Sergiy Byelozyorov, 2016-10-05 13:06:23]

The CQ bit was checked by sergiyb@chromium.org

[commit-bot: I haz the power, 2016-10-05 13:06:25]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-05 13:20:24]

Description was changed from

==========
Report all flakes reported to issue tracker also to FindIt

R=stgao@chromium.org
BUG=652341
==========

to

==========
Report all flakes reported to issue tracker also to FindIt

R=stgao@chromium.org
BUG=652341

Committed:
https://chromium.googlesource.com/infra/infra/+/4bd270034f02650027a8f3b5ab153...
==========

[commit-bot: I haz the power, 2016-10-05 13:20:26]

Committed patchset #4 (id:70001) as
https://chromium.googlesource.com/infra/infra/+/4bd270034f02650027a8f3b5ab153...