Fix SchemeHostPort::GetURL() and add more tests

Fix SchemeHostPort::GetURL() and add more tests

The implementation erroneously
 - Added an extra / to invalid URLs
 - Populated empty (len 0) url::Parsed components when they were empty in
   the class. Instead, they should have begin 0 and len -1.

BUG=651554
Committed: https://crrev.com/6fbc9faa8aad3b74423c32254148eba990a8c069
Cr-Commit-Position: refs/heads/master@{#424059}

[Charlie Harrison, 2016-10-04 13:10:31]

The CQ bit was checked by csharrison@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-04 13:10:48]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Charlie Harrison, 2016-10-04 13:41:07]

csharrison@chromium.org changed reviewers:
+ brettw@chromium.org

[Charlie Harrison, 2016-10-04 13:41:08]

Hey Brett,
There were a few problems with the Origin::GetURL() patch that were due to poor
test coverage of SchemeHostPort::GetURL(). I've added tests which uncovered a
few edge cases (mostly for invalid SchemeHostPorts).

PTAL?

[commit-bot: I haz the power, 2016-10-04 13:58:52]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-04 13:58:53]

Dry run: This issue passed the CQ dry run.

[brettw, 2016-10-07 17:22:09]

lgtm

[Charlie Harrison, 2016-10-07 18:08:52]

The CQ bit was checked by csharrison@chromium.org

[commit-bot: I haz the power, 2016-10-07 18:09:10]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-07 19:58:08]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-07 19:58:09]

Try jobs failed on following builders:
  win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[Charlie Harrison, 2016-10-08 02:33:46]

The CQ bit was checked by csharrison@chromium.org

[commit-bot: I haz the power, 2016-10-08 02:34:06]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-08 03:32:22]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-10-08 03:35:18]

Description was changed from

==========
Fix SchemeHostPort::GetURL() and add more tests

The implementation erroneously
 - Added an extra / to invalid URLs
 - Populated empty (len 0) url::Parsed components when they were empty in
   the class. Instead, they should have begin 0 and len -1.

BUG=651554
==========

to

==========
Fix SchemeHostPort::GetURL() and add more tests

The implementation erroneously
 - Added an extra / to invalid URLs
 - Populated empty (len 0) url::Parsed components when they were empty in
   the class. Instead, they should have begin 0 and len -1.

BUG=651554

Committed: https://crrev.com/6fbc9faa8aad3b74423c32254148eba990a8c069
Cr-Commit-Position: refs/heads/master@{#424059}
==========

[commit-bot: I haz the power, 2016-10-08 03:35:19]

Patchset 1 (id:??) landed as
https://crrev.com/6fbc9faa8aad3b74423c32254148eba990a8c069
Cr-Commit-Position: refs/heads/master@{#424059}