Issue 238713003: Handlify PrepareSlowElementsForSort and JSArrayUpdateLengthFromIndex.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 238713003: Handlify PrepareSlowElementsForSort and JSArrayUpdateLengthFromIndex. (Closed)

Created:
6 years, 8 months ago by Yang

Modified:
6 years, 8 months ago

Reviewers:
mvstanton

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Handlify PrepareSlowElementsForSort and JSArrayUpdateLengthFromIndex. R=mvstanton@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=20757

Patch Set 1 #

Total comments: 1

Created: 6 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+62 lines, -95 lines)			Patch
	M	src/objects.h	View		2 chunks	+2 lines, -5 lines	0 comments	Download
	M	src/objects.cc	View		2 chunks	+60 lines, -90 lines	1 comment	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

mvstanton

LGTM. https://codereview.chromium.org/238713003/diff/1/src/objects.cc File src/objects.cc (right): https://codereview.chromium.org/238713003/diff/1/src/objects.cc#newcode14593 src/objects.cc:14593: return isolate->factory()->NewNumberFromUint(result); Nice consolidation to use NewNumberFromUint().

6 years, 8 months ago (2014-04-15 09:56:19 UTC) #2

Yang

6 years, 8 months ago (2014-04-15 10:30:08 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r20757 (presubmit successful).

Expand Messages | Collapse Messages