Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2408)

Unified Diff: content/public/browser/render_process_host.h

Issue 2387113004: Better bad message reporting from IO thread (Closed)
Patch Set: cleanup Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/public/browser/render_process_host.h
diff --git a/content/public/browser/render_process_host.h b/content/public/browser/render_process_host.h
index fd4805219d9a612c85ffa403d3f224fc6f9c4512..26378cca406e4a47db602fa52bb97dfe6990dbf6 100644
--- a/content/public/browser/render_process_host.h
+++ b/content/public/browser/render_process_host.h
@@ -65,6 +65,12 @@ class CONTENT_EXPORT RenderProcessHost : public IPC::Sender,
int exit_code;
};
+ // Crash reporting mode for ShutdownForBadMessage.
+ enum class CrashReportMode {
+ NO_CRASH_DUMP,
+ GENERATE_CRASH_DUMP,
+ };
+
// General functions ---------------------------------------------------------
~RenderProcessHost() override {}
@@ -95,7 +101,10 @@ class CONTENT_EXPORT RenderProcessHost : public IPC::Sender,
// Most callers should not call this directly, but instead should call
// bad_message::BadMessageReceived() or an equivalent method outside of the
// content module.
- virtual void ShutdownForBadMessage() = 0;
+ //
+ // If |crash_report_mode| is GENERATE_CRASH_DUMP, then a browser crash dump
+ // will be reported as well.
+ virtual void ShutdownForBadMessage(CrashReportMode crash_report_mode) = 0;
// Track the count of visible widgets. Called by listeners to register and
// unregister visibility.

Powered by Google App Engine
This is Rietveld 408576698