Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(110)

Side by Side Diff: components/password_manager/content/browser/bad_message.cc

Issue 2387113004: Better bad message reporting from IO thread (Closed)
Patch Set: cleanup Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "components/password_manager/content/browser/bad_message.h" 5 #include "components/password_manager/content/browser/bad_message.h"
6 6
7 #include "base/logging.h" 7 #include "base/logging.h"
8 #include "base/metrics/sparse_histogram.h" 8 #include "base/metrics/sparse_histogram.h"
9 #include "content/public/browser/render_process_host.h" 9 #include "content/public/browser/render_process_host.h"
10 10
11 namespace password_manager { 11 namespace password_manager {
12 namespace bad_message { 12 namespace bad_message {
13 13
14 void ReceivedBadMessage(content::RenderProcessHost* host, 14 void ReceivedBadMessage(content::RenderProcessHost* host,
15 BadMessageReason reason) { 15 BadMessageReason reason) {
16 LOG(ERROR) 16 LOG(ERROR)
17 << "Terminating renderer for bad PasswordManager IPC message, reason " 17 << "Terminating renderer for bad PasswordManager IPC message, reason "
18 << static_cast<int>(reason); 18 << static_cast<int>(reason);
19 UMA_HISTOGRAM_SPARSE_SLOWLY("Stability.BadMessageTerminated.PasswordManager", 19 UMA_HISTOGRAM_SPARSE_SLOWLY("Stability.BadMessageTerminated.PasswordManager",
20 static_cast<int>(reason)); 20 static_cast<int>(reason));
21 host->ShutdownForBadMessage(); 21 host->ShutdownForBadMessage(
22 content::RenderProcessHost::CrashReportMode::GENERATE_CRASH_DUMP);
22 } 23 }
23 24
24 } // namespace bad_message 25 } // namespace bad_message
25 } // namespace password_manager 26 } // namespace password_manager
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698