Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(406)

Side by Side Diff: chrome/browser/bad_message.cc

Issue 2387113004: Better bad message reporting from IO thread (Closed)
Patch Set: cleanup Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/bad_message.h" 5 #include "chrome/browser/bad_message.h"
6 6
7 #include "base/logging.h" 7 #include "base/logging.h"
8 #include "base/metrics/sparse_histogram.h" 8 #include "base/metrics/sparse_histogram.h"
9 #include "content/public/browser/browser_message_filter.h" 9 #include "content/public/browser/browser_message_filter.h"
10 #include "content/public/browser/render_process_host.h" 10 #include "content/public/browser/render_process_host.h"
11 11
12 namespace bad_message { 12 namespace bad_message {
13 13
14 namespace { 14 namespace {
15 15
16 void LogBadMessage(BadMessageReason reason) { 16 void LogBadMessage(BadMessageReason reason) {
17 LOG(ERROR) << "Terminating renderer for bad IPC message, reason " << reason; 17 LOG(ERROR) << "Terminating renderer for bad IPC message, reason " << reason;
18 UMA_HISTOGRAM_SPARSE_SLOWLY("Stability.BadMessageTerminated.Chrome", reason); 18 UMA_HISTOGRAM_SPARSE_SLOWLY("Stability.BadMessageTerminated.Chrome", reason);
19 } 19 }
20 20
21 } // namespace 21 } // namespace
22 22
23 void ReceivedBadMessage(content::RenderProcessHost* host, 23 void ReceivedBadMessage(content::RenderProcessHost* host,
24 BadMessageReason reason) { 24 BadMessageReason reason) {
25 LogBadMessage(reason); 25 LogBadMessage(reason);
26 host->ShutdownForBadMessage(); 26 host->ShutdownForBadMessage(
27 content::RenderProcessHost::CrashReportMode::GENERATE_CRASH_DUMP);
27 } 28 }
28 29
29 void ReceivedBadMessage(content::BrowserMessageFilter* filter, 30 void ReceivedBadMessage(content::BrowserMessageFilter* filter,
30 BadMessageReason reason) { 31 BadMessageReason reason) {
31 LogBadMessage(reason); 32 LogBadMessage(reason);
32 filter->ShutdownForBadMessage(); 33 filter->ShutdownForBadMessage();
33 } 34 }
34 35
35 } // namespace bad_message 36 } // namespace bad_message
OLDNEW
« no previous file with comments | « no previous file | components/password_manager/content/browser/bad_message.cc » ('j') | content/browser/bad_message.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698