third_party/WebKit/Source/modules/canvas2d/CanvasRenderingContext2DState.cpp - Issue 2387093002: Reflow comments in canvas-related folders

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/canvas2d/CanvasRenderingContext2DState.cpp

Issue 2387093002: Reflow comments in canvas-related folders (Closed)

Patch Set: Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/modules/canvas2d/CanvasRenderingContext2DState.h ('K') | « third_party/WebKit/Source/modules/canvas2d/CanvasRenderingContext2DState.h ('k') | third_party/WebKit/Source/modules/canvas2d/CanvasRenderingContext2DTest.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/canvas2d/CanvasRenderingContext2DState.cpp

diff --git a/third_party/WebKit/Source/modules/canvas2d/CanvasRenderingContext2DState.cpp b/third_party/WebKit/Source/modules/canvas2d/CanvasRenderingContext2DState.cpp

index f5d68b56536d362eee5020922e37c10c4ab00a66..ed40951e2228a77aacb4b2e264c93c87561c0fc8 100644

--- a/third_party/WebKit/Source/modules/canvas2d/CanvasRenderingContext2DState.cpp

+++ b/third_party/WebKit/Source/modules/canvas2d/CanvasRenderingContext2DState.cpp

@@ -303,8 +303,8 @@ SkImageFilter* CanvasRenderingContext2DState::getFilter(

*m_filterValue);

resolverState.loadPendingResources();

- // We can't reuse m_fillPaint and m_strokePaint for the filter, since these incorporate

- // the global alpha, which isn't applicable here.

+ // We can't reuse m_fillPaint and m_strokePaint for the filter, since these

+ // incorporate the global alpha, which isn't applicable here.

SkPaint fillPaintForFilter;

m_fillStyle->applyToPaint(fillPaintForFilter);

fillPaintForFilter.setColor(m_fillStyle->paintColor());

@@ -520,7 +520,8 @@ const SkPaint* CanvasRenderingContext2DState::getPaint(

break;

default:

ASSERT_NOT_REACHED();

- // no break on purpose: paint needs to be assigned to avoid compiler warning about uninitialized variable

+ // no break on purpose: paint needs to be assigned to avoid compiler warning

+ // about uninitialized variable

Justin Novosad 2016/10/03 18:13:11 period

case FillPaintType:

updateFillStyle();

paint = &m_fillPaint;