Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(257)

Issue 2387073002: reflow comments in Source/bindings/modules/v8 (Closed)

Created:
4 years, 2 months ago by Nico
Modified:
4 years, 2 months ago
Reviewers:
haraken
CC:
chromium-reviews, blink-reviews, blink-reviews-bindings_chromium.org, jbroman+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

reflow comments in Source/bindings/modules/v8 BUG=563793 Committed: https://crrev.com/66c9f33db7aa115b6385ca256979f5cd6bd90ad7 Cr-Commit-Position: refs/heads/master@{#422795}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -6 lines) Patch
M third_party/WebKit/Source/bindings/modules/v8/ConditionalFeaturesForModules.cpp View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/bindings/modules/v8/SerializedScriptValueForModulesFactory.cpp View 1 chunk +3 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/bindings/modules/v8/V8BindingForModules.cpp View 2 chunks +4 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/bindings/modules/v8/custom/V8CustomSQLStatementErrorCallback.cpp View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 13 (7 generated)
Nico
4 years, 2 months ago (2016-10-03 15:27:48 UTC) #4
Nico
ping? :-)
4 years, 2 months ago (2016-10-04 13:32:46 UTC) #7
haraken
LGTM
4 years, 2 months ago (2016-10-04 14:52:15 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2387073002/1
4 years, 2 months ago (2016-10-04 15:02:06 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-04 15:07:49 UTC) #11
commit-bot: I haz the power
4 years, 2 months ago (2016-10-04 15:11:06 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/66c9f33db7aa115b6385ca256979f5cd6bd90ad7
Cr-Commit-Position: refs/heads/master@{#422795}

Powered by Google App Engine
This is Rietveld 408576698