Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(315)

Issue 2387063004: media: Fix gn deps on //media/test (Closed)

Created:
4 years, 2 months ago by jrummell
Modified:
4 years, 2 months ago
CC:
chromium-reviews, feature-media-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

media: Fix gn deps on //media/test BUG=599578 TEST=gn check //media/test/* is clean Committed: https://crrev.com/5216c61da3efaa82761756b4a78fb13351f35452 Cr-Commit-Position: refs/heads/master@{#423380}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -3 lines) Patch
M .gn View 2 chunks +1 line, -1 line 0 comments Download
M media/test/BUILD.gn View 3 chunks +6 lines, -2 lines 0 comments Download

Messages

Total messages: 15 (8 generated)
jrummell
PTAL. Changes to DEPS so that GN can start enforcing the rules on the media/test ...
4 years, 2 months ago (2016-10-04 23:12:15 UTC) #6
sandersd (OOO until July 31)
lgtm
4 years, 2 months ago (2016-10-04 23:15:17 UTC) #7
jrummell
+brettw@ for OWNERS review of .gn
4 years, 2 months ago (2016-10-04 23:20:11 UTC) #9
brettw
yay, lgtm
4 years, 2 months ago (2016-10-04 23:25:54 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2387063004/1
4 years, 2 months ago (2016-10-05 22:15:01 UTC) #12
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-06 01:30:50 UTC) #13
commit-bot: I haz the power
4 years, 2 months ago (2016-10-06 01:32:37 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/5216c61da3efaa82761756b4a78fb13351f35452
Cr-Commit-Position: refs/heads/master@{#423380}

Powered by Google App Engine
This is Rietveld 408576698