Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(217)

Side by Side Diff: chrome/browser/resources/settings/people_page/people_page.js

Issue 2387063003: [MD Settings][People] sync icon instead of checkmark to represent successful sync (Closed)
Patch Set: Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « chrome/browser/resources/settings/people_page/people_page.html ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 /** 5 /**
6 * @fileoverview 6 * @fileoverview
7 * 'settings-people-page' is the settings page containing sign-in settings. 7 * 'settings-people-page' is the settings page containing sign-in settings.
8 */ 8 */
9 Polymer({ 9 Polymer({
10 is: 'settings-people-page', 10 is: 'settings-people-page',
(...skipping 329 matching lines...) Expand 10 before | Expand all | Expand 10 after
340 * @return {string} 340 * @return {string}
341 */ 341 */
342 getSyncIcon_: function(syncStatus) { 342 getSyncIcon_: function(syncStatus) {
343 if (!syncStatus) 343 if (!syncStatus)
344 return ''; 344 return '';
345 if (syncStatus.hasError) 345 if (syncStatus.hasError)
346 return 'settings:sync-problem'; 346 return 'settings:sync-problem';
347 if (syncStatus.managed) 347 if (syncStatus.managed)
348 return 'settings:sync-disabled'; 348 return 'settings:sync-disabled';
349 349
350 return 'settings:done'; 350 return 'settings:sync';
351 }, 351 },
352 352
353 /** 353 /**
354 * @param {string} iconUrl 354 * @param {string} iconUrl
355 * @return {string} A CSS imageset for multiple scale factors. 355 * @return {string} A CSS imageset for multiple scale factors.
356 * @private 356 * @private
357 */ 357 */
358 getIconImageset_: function(iconUrl) { 358 getIconImageset_: function(iconUrl) {
359 return cr.icon.getImage(iconUrl); 359 return cr.icon.getImage(iconUrl);
360 }, 360 },
361 361
362 /** 362 /**
363 * @return {boolean} Whether to show the "Sign in to Chrome" button. 363 * @return {boolean} Whether to show the "Sign in to Chrome" button.
364 * @private 364 * @private
365 */ 365 */
366 showSignin_: function(syncStatus) { 366 showSignin_: function(syncStatus) {
367 return syncStatus.signinAllowed && !syncStatus.signedIn; 367 return syncStatus.signinAllowed && !syncStatus.signedIn;
368 }, 368 },
369 }); 369 });
OLDNEW
« no previous file with comments | « chrome/browser/resources/settings/people_page/people_page.html ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698